upcoming: [UIE-9742] - Implement disabling of required functionalities when a linode is locked. by tanushree-akamai · Pull Request #13377 · linode/manager

tanushree-akamai · 2026-02-06T13:34:21Z

Description 📝

This PR implements disabling of delete and rebuild actions when a Linode has active locks, with appropriate tooltips and warning messages. When a cannot_delete_with_subresources lock is present, delete operations for Linode subresources (Disks, Configurations, and IP Addresses) are also disabled with appropriate tooltip.

Changes 🔄

Delete and rebuild actions is disabled with a tooltip in both Linode action menu and the settings page.
Rebuild Modal via Bookmarked URL shows warning message when lock is active with rebuild button disabled.
In case cannot_delete_with_subresources lock is applied, in addition to above:
Delete Disk option greyed out with tooltip (Storage tab)
Delete IP Address option greyed out with tooltip (Network tab)
Delete Config option greyed out with tooltip (Configurations tab)

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Preview 📷

Delete option greyed out with tooltip in action menu in Linodes list
Rebuild option greyed out with tooltip in action menu in Linodes list
Delete option greyed out in action menu in Linode detail screen
Rebuild option greyed out in action menu Linode detail screen
Delete option greyed out on Linode settings page
Rebuild modal through a bookmarked url
Delete IP Address option greyed out with tooltip in Linode Network tab.
Delete Disk option greyed out with tooltip in Linode Storage tab.
Delete Config option greyed out with tooltip in Linode Configurations tab.

How to test 🧪

Reproduction steps

Verification steps

Navigate to /linodes
Click on Linode action menu and select Lock
Apply Lock
Verify above mentioned scenarios

⚠️ This is a temporary workaround for testing only
Since IAM permissions for Resource Locks are not fully implemented yet, you can temporarily bypass the permission checks to validate the Lock/Unlock behavior with real API data.
Comment the permission checks on line 247 in LinodeActionMenu.tsx:

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…s when a linode is locked.

…hen a Linode has active locks

…and Remove Lock modal titles.

bnussman-akamai · 2026-02-09T20:10:55Z

packages/manager/src/features/Linodes/constants.ts

+
+// Lock-related constants
+export const LINODE_LOCKED_DELETE_TOOLTIP =
+  "You don't have permission to delete this linode.";


Suggested change

"You don't have permission to delete this linode.";

"You don't have permission to delete this Linode.";

Addressed in commit 9e4d51b

bnussman-akamai · 2026-02-09T20:28:50Z

...ages/manager/src/features/Linodes/LinodesDetail/LinodeSettings/LinodeSettingsDeletePanel.tsx

+          <Tooltip
+            placement="bottom-start"
+            title={LINODE_LOCKED_DELETE_TOOLTIP}
+          >
+            <span>{deleteButton}</span>
+          </Tooltip>


This is okay but our Button component has a tooltipText prop on it. Would it make sense to leverage that feature here?

https://design.linode.com/?path=/story/foundations-button--disabled-tooltip

Addressed in commit 9e4d51b

bnussman-akamai · 2026-02-09T20:33:38Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeIPAddressRow.tsx

+  const isLinodeSubResourcesLocked =
+    !!linode?.locks?.length &&
+    linode.locks.includes('cannot_delete_with_subresources');


Is the !!linode?.locks?.length part necessary?

We may be able to simplify it a bit:

Suggested change

const isLinodeSubResourcesLocked =

!!linode?.locks?.length &&

linode.locks.includes('cannot_delete_with_subresources');

const isLinodeSubResourcesLocked = linode?.locks?.includes('cannot_delete_with_subresources') ?? false;

Addressed in commit 9e4d51b

bnussman-akamai

grevanak-akamai · 2026-02-10T10:44:34Z

packages/manager/src/features/Linodes/constants.ts

+
+// Lock-related constants
+export const LINODE_LOCKED_DELETE_TOOLTIP =
+  "You don't have permission to delete this Linode.";


This message conveys IAM permission issue rather than just for resource lock. To me, message added for rebuild looks correct and shouldn't it be conveyed in rest of the messages too?

I had conveyed the same to Karthik. Since this isn’t a high priority right now and the feature won’t be toggled on, he’ll revisit it later. For now we will go with what we have in figma.

grevanak-akamai · 2026-02-10T10:56:35Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/LinodeConfigActionMenu.tsx

Similar to this, we need to block deletion of linode interfaces too here. This is mentioned in API doc too

Good catch! Addressed in a320ced

grevanak-akamai · 2026-02-10T11:06:30Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx

+      {isLocked && (
+        <Notice
+          spacingBottom={16}
+          text={LINODE_LOCKED_DELETE_CONFIG_TOOLTIP}


This message is for linode config profiles right? We need to have a separate message here

Addressed in a320ced

grevanak-akamai

Changes looks good. Thanks @tanushree-akamai

…nality-on-lock

linode-gh-bot · 2026-02-12T09:24:52Z

Cloud Manager UI test results

🔺 1 failing test on test run #8 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`865 Passing`	`11 Skipped`	`39m 38s`

Details

Failing Tests
	Spec	Test
❌	`one-click-apps.spec.ts`	Cloud Manager Cypress Tests→OneClick Apps (OCA) » Can view app details of a marketplace app

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/oneClickApps/one-click-apps.spec.ts"

tanushree-akamai requested review from bnussman-akamai, dwiley-akamai, grevanak-akamai, harsh-akamai, pmakode-akamai and tvijay-akamai February 6, 2026 13:34

tanushree-akamai self-assigned this Feb 6, 2026

tanushree-akamai requested a review from a team as a code owner February 6, 2026 13:34

tanushree-akamai added Ready for Review RESPROT-2 Resource Locking labels Feb 6, 2026

github-project-automation bot added this to Cloud Manager Feb 6, 2026

github-project-automation bot moved this to Review in Cloud Manager Feb 6, 2026

tanushree-akamai removed the Ready for Review label Feb 6, 2026

upcoming: [UIE-9742] - Implement disabling of required functionalitie…

2cdb4f0

…s when a linode is locked.

tanushree-akamai force-pushed the feature/UIE-9742-disable-required-functionality-on-lock branch from 2385136 to 2cdb4f0 Compare February 6, 2026 14:45

Added changeset: Implements disabling of delete and rebuild actions w…

a650ff8

…hen a Linode has active locks

tanushree-akamai added the Ready for Review label Feb 6, 2026

upcoming: [UIE-9742] - Demo feedback to add linode label to Add Lock …

8f935e6

…and Remove Lock modal titles.

bnussman-akamai reviewed Feb 9, 2026

View reviewed changes

Addressed review comments from

9e4d51b

bnussman-akamai

tanushree-akamai requested a review from bnussman-akamai February 10, 2026 08:31

grevanak-akamai reviewed Feb 10, 2026

View reviewed changes

Addressed review comments from Ganesh.

a320ced

tanushree-akamai requested a review from grevanak-akamai February 11, 2026 07:29

grevanak-akamai approved these changes Feb 11, 2026

View reviewed changes

grevanak-akamai added the Add'tl Approval Needed Waiting on another approval! label Feb 11, 2026

bnussman-akamai approved these changes Feb 11, 2026

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 11, 2026

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Feb 11, 2026

tanushree-akamai removed the Ready for Review label Feb 12, 2026

Merge branch 'develop' into feature/UIE-9742-disable-required-functio…

6f0c900

…nality-on-lock

tanushree-akamai merged commit b8f3057 into linode:develop Feb 12, 2026
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 12, 2026

This was referenced Feb 19, 2026

Release v1.159.0 - release → staging #13416

Closed

Release v1.159.0 - release → staging #13417

Closed

Release v1.159.0 - release → staging #13422

Merged

Release v1.159.0 - staging → master #13429

Merged

	"You don't have permission to delete this linode.";
	"You don't have permission to delete this Linode.";

Conversation

tanushree-akamai commented Feb 6, 2026

Description 📝

Changes 🔄

Scope 🚢

Preview 📷

How to test 🧪

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grevanak-akamai Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grevanak-akamai Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tanushree-akamai Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grevanak-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Feb 12, 2026

Cloud Manager UI test results

🔺 1 failing test on test run #8 ↗︎

Details

Troubleshooting

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bnussman-akamai Feb 9, 2026 •

edited

Loading

grevanak-akamai Feb 10, 2026 •

edited

Loading

grevanak-akamai Feb 10, 2026 •

edited

Loading

tanushree-akamai Feb 10, 2026 •

edited

Loading