Skip to content

fix: [UIE-10040] - IAM Delegation: Default Entity Access disable Remove button when loading#13290

Merged
mpolotsk-akamai merged 3 commits intolinode:developfrom
mpolotsk-akamai:UIE-10040-default-entity-remove-btn
Jan 22, 2026
Merged

fix: [UIE-10040] - IAM Delegation: Default Entity Access disable Remove button when loading#13290
mpolotsk-akamai merged 3 commits intolinode:developfrom
mpolotsk-akamai:UIE-10040-default-entity-remove-btn

Conversation

@mpolotsk-akamai
Copy link
Copy Markdown
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Jan 16, 2026

Description 📝

This PR fixes an issue where the “Remove” button was not disabled after clicking it in the Default Entity Access confirmation popup.

Changes 🔄

List any change(s) relevant to the reviewer.

  • added "is removing" state to disable button

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test 🧪

Prerequisites

(How to setup test environment)

  • use IAM Child Account

Verification steps

(How to verify changes)

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai self-assigned this Jan 16, 2026
@mpolotsk-akamai mpolotsk-akamai added the IAM Delegation Implementing the new Parent/Child delegation UI label Jan 16, 2026
@mpolotsk-akamai mpolotsk-akamai marked this pull request as ready for review January 16, 2026 14:54
…onfirmation popup is not disabled after clicking it
@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner January 16, 2026 14:56
@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped38m 37s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

export const RemoveAssignmentConfirmationDialog = (props: Props) => {
const { onClose: _onClose, onSuccess, open, role, username } = props;

const [isRemoving, setIsRemoving] = useState(false);
Copy link
Copy Markdown
Contributor

@abailly-akamai abailly-akamai Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, when dealing with pending queries we don't need to add a custom state: we already have it available in React Query.

Instead just do:

const {
    error,
    isPending: isUserRolesPending,
    mutateAsync: updateUserRoles,
    reset,
  } = useUserRolesMutation(username ?? '');

  const {
    mutateAsync: updateDefaultDelegationRoles,
    isPending: isDefaultDelegationRolesPending,
  } = useUpdateDefaultDelegationAccessQuery();

 const isPending = isUserRolesPending || isDefaultDelegationRolesPending;

then in the component:

primaryButtonProps={{
  disabled: isPending,
  label: 'Remove',
  loading: isPending,
  onClick: onDelete,
}}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Updated.

Copy link
Copy Markdown
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 22, 2026
@mpolotsk-akamai mpolotsk-akamai merged commit 2340b1c into linode:develop Jan 22, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 22, 2026
dchyrva-akamai pushed a commit to dchyrva-akamai/manager that referenced this pull request Jan 26, 2026
…ve button when loading (linode#13290)

* fix: [UIE-10040] - IAM Delegation: Default Entity Access disable Remove button when loading

* Added changeset: IAM Delegation: Remove button in remove assignment confirmation popup is not disabled after clicking it

* review fix
dchyrva-akamai pushed a commit to dchyrva-akamai/manager that referenced this pull request Jan 27, 2026
…ve button when loading (linode#13290)

* fix: [UIE-10040] - IAM Delegation: Default Entity Access disable Remove button when loading

* Added changeset: IAM Delegation: Remove button in remove assignment confirmation popup is not disabled after clicking it

* review fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants