upcoming: [UIE-9730] - Add Beta/New Feature Chip Support for RuleSets and Prefix Lists#13164
Merged
pmakode-akamai merged 11 commits intolinode:developfrom Dec 5, 2025
Conversation
…t-for-ruleset-prefixlist
pmakode-akamai
requested review from
fabrice-akamai and
grevanak-akamai
and removed request for
a team
harsh-akamai
approved these changes
Dec 4, 2025
Contributor
harsh-akamai
left a comment
harsh-akamai
left a comment
There was a problem hiding this comment.
Thanks @pmakode-akamai!
Contributor
|
I believe this PR is missing a changeset. Please do add it before merging |
pmakode-akamai
added
Add'tl Approval Needed
grevanak-akamai
approved these changes
Dec 4, 2025
tanushree-akamai
approved these changes
Dec 4, 2025
packages/manager/src/features/Firewalls/FirewallDetail/Rules/FirewallRuleDrawer.test.tsx
Show resolved
Hide resolved
| isFirewallRulesetsPrefixListsGAEnabled, | ||
| }) ?? undefined; | ||
|
|
||
| // Do not show the Firewall RS & PL feature chip in Edit mode drawer title |
Contributor
There was a problem hiding this comment.
Good that we commented the condition 👍
dwiley-akamai
approved these changes
Dec 4, 2025
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Verification steps ✅
Did program leadership provide any guidance about a Limited Availability (LA) period?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add Beta/New Feature Chip Support for RuleSets and Prefix Lists
Changes 🔄
Scope 🚢
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅