fix: [M3-10679] - NodeBalancer Configuration form unresponsiveness for larger VPC deployments by bnussman-akamai · Pull Request #12991 · linode/manager

bnussman-akamai · 2025-10-15T20:11:45Z

Description 📝

This PR fix unresponsiveness on the NodeBalancer configurations page for larger NodeBalancer + VPC deployments but also includes some other fixes too.

Fixes 🔧

Fixes problematic "n + 1" data fetching on the NodeBalancer Configurations page (primary fix 🔧 )
Fixes missing input IDs causing accessibility issues with NodeBalancer Port and Weight fields
Fixes missing React Query cache invalidation

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Preview 📷

Before	After

Makes 1 request per Linode (in the region) to `/v4/linode/instaces/:id/ips`. This was resulting in +400 requests to the API at once for a customer	Uses 1 request to `/v4beta/vpcs/:id/ips`

How to test 🧪

Prerequisites

Create a NodeBalancer that uses a VPC
Create some Linodes in the same VPC
Add those Linodes as NodeBalancer nodes

Reproduction steps

To replicate the performance issues, you need a large account, but you can still test this PR with any size account to ensure Cloud Manager still works as expected.

Verification steps

Test functionality and performance of the NodeBalancer Configuration form (create page and details page)
This PR's changes should be transparent to the user. Verify functionality is the same as prodiction.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

bnussman-akamai · 2025-10-15T20:17:34Z

packages/manager/src/hooks/useDataForLinodesInVPC.ts

-  const linodeIPQueries = useQueries({
-    queries:
-      linodesData?.map<UseQueryOptions<LinodeIPsResponse, APIError[]>>(
-        ({ id }) => ({
-          ...linodeQueries.linode(id)._ctx.ips,
-          enabled: isSubnetSelected,
-        })
-      ) ?? [],
-  });


This was the problematic code causing performance issues. The code itself is fine, but isn't scaling well for customers that have hundres of Linodes.

I was able to remove this and use useVPCIPsQuery (/v4beta/vpcs/:id/ips) instead

bnussman-akamai · 2025-10-15T20:23:36Z

packages/manager/src/hooks/useDataForLinodesInVPC.ts

  const {
-    data: subnetsData,
-    error: subnetsError,
-    isLoading: subnetsIsLoading,
-  } = useSubnetsQuery(Number(vpcId), {}, {}, isSubnetSelected);


This is not the primary fix but...

Using useSubnetsQuery here would cause bugs for VPCs with more than 100 subnets (100 is the default API page size). useSubnetsQuery is paginated but getVPCIPOptions expects all subnets to be passed.

I removed useSubnetsQuery and replaced it with useVPCQuery which includes a subnets field, which includes all subnets in the VPC. This will eliminate the possibility of bugs for VPCs with more than 100 subnets .

bnussman-akamai · 2025-10-15T20:25:19Z

packages/manager/src/features/NodeBalancers/NodeBalancerConfigNode.tsx

                disabled={disabled}
                errorGroup={`${configIdx}`}
                errorText={nodesErrorMap.port}
+                inputId={`node-port-${configIdx}-${idx}`}


Added inputIds to fix this issue:

Screen.Recording.2025-10-15.at.4.24.55.PM.mov

bnussman-akamai · 2025-10-15T20:26:33Z

packages/queries/src/vpcs/vpcs.ts

        },
        queryKey: null,
      },
-      vpcIps: (vpcId: number, filter: Filter = {}) => ({


We don't need vpcId duplicated here. vpcId is already in scope

bnussman-akamai · 2025-10-15T20:29:40Z

packages/manager/src/features/NodeBalancers/ConfigNodeIPSelect.utils.ts

+    });
+  }

-  return options.sort((a, b) => a.label.localeCompare(b.label));


The API's default sorting is actually much nicer so I removed our client side sort call here.

With the sort call (Prod) Without the sort (This PR)

… larger VPC deployments

abailly-akamai

Nice thanks for the fixes - they all make sense to me.

While not being able to fully test it, did not notice any regressions

dwiley-akamai

Code review ✅
No regressions observed ✅
/v4/linode/instaces/:id/ips --> /v4beta/vpcs/:id/ips swap verified ✅

packages/queries/src/linodes/linodes.ts

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

linode-gh-bot · 2025-10-16T18:56:59Z

Cloud Manager UI test results

🔺 5 failing tests on test run #6 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`5 Failing`	`834 Passing`	`13 Skipped`	`40m 13s`

Details

Failing Tests
	Spec	Test
❌	`access-key.e2e.spec.ts`	Cloud Manager Cypress Tests→object storage access key end-to-end tests » "before all" hook for "can create an access key with unlimited access - e2e"
❌	`clone-linode.spec.ts`	Cloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page
❌	`object-storage-objects-multicluster.spec.ts`	Cloud Manager Cypress Tests→Object Storage Multicluster objects » "before all" hook for "can upload, access, and delete objects"
❌	`timerange-verification.spec.ts`	Cloud Manager Cypress Tests→Integration tests for verifying Cloudpulse custom and preset configurations » should implement and validate custom date/time picker for a specific date and time range
❌	`object-storage.e2e.spec.ts`	Cloud Manager Cypress Tests→object storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

@dwiley-akamai

…r larger VPC deployments (linode#12991) * use vpc ips endpoint (work in progress) * improve things more * clean up * fix typecheck * other bug fixes * Added changeset: NodeBalancer Configuration form unresponsiveness for larger VPC deployments * update cypress tests * make code a bit safer * Apply suggestion from @dwiley-akamai Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * Apply suggestion from @dwiley-akamai Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> --------- Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

bnussman-akamai added 5 commits October 15, 2025 11:14

use vpc ips endpoint (work in progress)

6041d8f

improve things more

1eb926a

clean up

3ac5b26

fix typecheck

08f1bbb

other bug fixes

4bf16d2

bnussman-akamai self-assigned this Oct 15, 2025

bnussman-akamai added Bug Fixes for regressions or bugs VPC Relating to VPC project NodeBalancers Relating to NodeBalancers labels Oct 15, 2025

github-project-automation bot added this to Cloud Manager Oct 15, 2025

github-project-automation bot moved this to Review in Cloud Manager Oct 15, 2025

bnussman-akamai commented Oct 15, 2025

View reviewed changes

bnussman-akamai marked this pull request as ready for review October 15, 2025 20:36

bnussman-akamai requested a review from a team as a code owner October 15, 2025 20:36

Added changeset: NodeBalancer Configuration form unresponsiveness for…

5f54dd0

… larger VPC deployments

bnussman-akamai added the Related Cypress Test Failure Test failure(s) are the result of changes in this PR and must be addressed before merging. label Oct 15, 2025

abailly-akamai approved these changes Oct 16, 2025

View reviewed changes

update cypress tests

e0774a1

bnussman-akamai requested a review from a team as a code owner October 16, 2025 16:10

bnussman-akamai requested review from cliu-akamai and removed request for a team October 16, 2025 16:10

bnussman-akamai removed the Related Cypress Test Failure Test failure(s) are the result of changes in this PR and must be addressed before merging. label Oct 16, 2025

dwiley-akamai approved these changes Oct 16, 2025

View reviewed changes

packages/queries/src/linodes/linodes.ts Outdated Show resolved Hide resolved

packages/queries/src/linodes/linodes.ts Outdated Show resolved Hide resolved

github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 16, 2025

bnussman-akamai and others added 3 commits October 16, 2025 14:07

make code a bit safer

16ad0c7

Apply suggestion from @dwiley-akamai

7e35043

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

Apply suggestion from @dwiley-akamai

5d10347

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

bnussman-akamai merged commit 51444b7 into linode:develop Oct 16, 2025
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 16, 2025

This was referenced Oct 30, 2025

Release v1.154.0 - release → staging #13040

Merged

Release v1.154.0 - staging → master #13053

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: [M3-10679] - NodeBalancer Configuration form unresponsiveness for larger VPC deployments#12991

fix: [M3-10679] - NodeBalancer Configuration form unresponsiveness for larger VPC deployments#12991
bnussman-akamai merged 10 commits intolinode:developfrom
bnussman-akamai:fix/nodebalancer-vpc-performance

bnussman-akamai commented Oct 15, 2025 •

edited

Loading

Uh oh!

bnussman-akamai Oct 15, 2025

Uh oh!

bnussman-akamai Oct 15, 2025

Uh oh!

bnussman-akamai Oct 15, 2025

Uh oh!

bnussman-akamai Oct 15, 2025

Uh oh!

bnussman-akamai Oct 15, 2025 •

edited

Loading

Uh oh!

abailly-akamai left a comment

Uh oh!

dwiley-akamai left a comment

Uh oh!

Uh oh!

Uh oh!

linode-gh-bot commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bnussman-akamai commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Fixes 🔧

Scope 🚢

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

bnussman-akamai Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abailly-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

linode-gh-bot commented Oct 16, 2025

Cloud Manager UI test results

🔺 5 failing tests on test run #6 ↗︎

Details

Troubleshooting

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bnussman-akamai commented Oct 15, 2025 •

edited

Loading

bnussman-akamai Oct 15, 2025 •

edited

Loading