Rewrite VARBINARY to BINARY in SparkSqlRewriter#593
Open
c-h-afzal wants to merge 1 commit intolinkedin:masterfrom
Open
Rewrite VARBINARY to BINARY in SparkSqlRewriter#593c-h-afzal wants to merge 1 commit intolinkedin:masterfrom
c-h-afzal wants to merge 1 commit intolinkedin:masterfrom
Conversation
c-h-afzal
changed the title
ruolin59
reviewed
Apr 10, 2026
coral-spark/src/test/java/com/linkedin/coral/spark/CoralSparkTest.java
Outdated
Show resolved
Hide resolved
ruolin59
reviewed
Apr 10, 2026
Calcite's type system uses VARBINARY for binary data, but Spark's SQL parser does not recognize VARBINARY as a valid cast target — it uses BINARY instead. When Hive views call base64() on string columns, Calcite inserts an implicit CAST(... AS VARBINARY) which produces unparseable Spark SQL, causing CoralSpark translation failures and downstream function registry poisoning via the DaliSpark Hive fallback path. This follows the same pattern already used by TrinoSqlRewriter, which rewrites BINARY/VARBINARY to Trino's VARBINARY in its convertTypeSpec method. Here we do the equivalent for Spark: rewrite VARBINARY to BINARY in SparkSqlRewriter.visit(SqlDataTypeSpec). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c-h-afzal
force-pushed
the
afzal/fix-varbinary-cast-spark-dialect
branch
from
a4e1adf to
f137382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calcite's type system uses VARBINARY for binary data, but Spark's SQL parser does not recognize VARBINARY as a valid cast target — it uses BINARY instead. When Hive views call base64() on string columns, Calcite inserts an implicit CAST(... AS VARBINARY) which produces unparseable Spark SQL, causing CoralSpark translation failures and downstream function registry poisoning via the DaliSpark Hive fallback path.
This follows the same pattern already used by TrinoSqlRewriter, which rewrites BINARY/VARBINARY to Trino's VARBINARY in its convertTypeSpec method. Here we do the equivalent for Spark: rewrite VARBINARY to BINARY in SparkSqlRewriter.visit(SqlDataTypeSpec).
Verified existing test cases pass and added a new test case.