[Coral-Hive/Spark/Trino] Rename dialect-agnostic Hive classes to Coral names#592
Open
wmoustafa wants to merge 1 commit intolinkedin:masterfrom
Open
[Coral-Hive/Spark/Trino] Rename dialect-agnostic Hive classes to Coral names#592wmoustafa wants to merge 1 commit intolinkedin:masterfrom
wmoustafa wants to merge 1 commit intolinkedin:masterfrom
Conversation
Create new Coral-named classes for dialect-agnostic implementations in coral-hive (12 classes), coral-spark (1 class), and coral-trino (1 class): - HiveRexBuilder -> CoralRexBuilder - HiveSqlConformance -> CoralSqlConformance - HiveSqlToRelConverter -> CoralSqlToRelConverter - HiveSqlValidator -> CoralSqlValidator - HiveViewExpander -> CoralViewExpander - HiveFunction -> CoralFunction - HiveExplodeOperator -> CoralExplodeOperator - HiveJsonTupleOperator -> CoralJsonTupleOperator - HiveNamedStructFunction -> CoralNamedStructFunction - HivePosExplodeOperator -> CoralPosExplodeOperator - HiveRLikeOperator -> CoralRLikeOperator - StaticHiveFunctionRegistry -> StaticCoralFunctionRegistry - HiveUDFTransformer -> CoralUDFTransformer (in coral-spark and coral-trino) Original Hive-named classes are retained as @deprecated thin wrappers for backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Several classes across
coral-hive,coral-spark, andcoral-trinohave "Hive" in their name despite being dialect-agnostic Calcite extensions. This PR renames them to "Coral" names to accurately reflect that they are not Hive-specific.coral-hive (12 classes):
HiveRexBuilderCoralRexBuilderHiveSqlConformanceCoralSqlConformanceHiveSqlToRelConverterCoralSqlToRelConverterHiveSqlValidatorCoralSqlValidatorHiveViewExpanderCoralViewExpanderHiveFunctionCoralFunctionHiveExplodeOperatorCoralExplodeOperatorHiveJsonTupleOperatorCoralJsonTupleOperatorHiveNamedStructFunctionCoralNamedStructFunctionHivePosExplodeOperatorCoralPosExplodeOperatorHiveRLikeOperatorCoralRLikeOperatorStaticHiveFunctionRegistryStaticCoralFunctionRegistrycoral-spark & coral-trino (1 class each):
HiveUDFTransformerCoralUDFTransformerOriginal Hive-named classes are retained as
@Deprecatedthin wrappers for backward compatibility. No breaking changes.How was this patch tested?
./gradlew :coral-hive:compileJava :coral-spark:compileJava :coral-trino:compileJava— all 3 modules compile successfully