[Coral-Trino] use 'TRY_CAST' instead of 'CAST'#544
Open
hqbhoho wants to merge 1 commit intolinkedin:masterfrom
Open
[Coral-Trino] use 'TRY_CAST' instead of 'CAST'#544hqbhoho wants to merge 1 commit intolinkedin:masterfrom
hqbhoho wants to merge 1 commit intolinkedin:masterfrom
Conversation
hqbhoho
force-pushed
the
feature/convert_cast_2_try_cast
branch
3 times, most recently
from
7dcd49f to
7ba254b
Compare
hqbhoho
force-pushed
the
feature/convert_cast_2_try_cast
branch
from
7ba254b to
bf86d94
Compare
Contributor
Author
|
@wmoustafa Could you help review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Hive/Spark CAST is equivalent to Trino TRY_CAST. If CAST fails, a query using Hive/Spark will return null, while a query using Trino will throw error. So I think should use 'TRY_CAST' instead of 'CAST'.
select cast('a' as int) return null
select cast('a' as int) throw error like "Cannot cast 'a' to INT"
select try_cast('a' as int) return null
How was this patch tested?
Modified unit tests.