Run microtasks after each script execution #1292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Dec 24, 2025
| log.debug(.browser, "executed script", .{ .src = url, .success = success, .on_load = script_element._on_load != null }); | ||
| } | ||
|
|
||
| defer page.tick(); |
Collaborator
There was a problem hiding this comment.
This'll run microtasks, scheduled tasks, and microtasks again, is that right?
Maybe it should just be:
_ = self.scheduler.run() catch |err| {
log.err(.page, "scheduler", .{ .err = err });
};
self.js.runMicrotasks();and remove page.tick.
Contributor
Author
There was a problem hiding this comment.
I think that makes more sense. I thought running macrotasks after a script execution is necessary.
This don't change the behavior for async and deferred scripts. just run microtasks after a script execution
nikneym
force-pushed
the
nikneym/script-execution-changes
branch
from
cc7acb2 to
b28ac8c
Compare
karlseguin
reviewed
Dec 24, 2025
|
|
||
| defer page.tick(); | ||
| // We should run microtasks even if script execution fails. | ||
| defer page.js.runMicrotasks(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| defer page.js.runMicrotasks(); | |
| defer { | |
| self.js.runMicrotasks(); | |
| _ = self.scheduler.run() catch |err| { | |
| log.err(.page, "scheduler", .{ .err = err }); | |
| }; | |
| } |
and you can remove the tick function from Page (I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This don't change the behavior for async and deferred scripts.