Reconstruction logic for padding bytes at the end of Reports (only possible for devices without ReportID)#707
Merged
Youw merged 2 commits intolibusb:masterfrom Oct 30, 2024
Conversation
…rt for devices which don't use ReportIDs -Enhanced padding logic to distinguish between byte and bit padding. -Add a new test case for Razer Cobra mouse `1532_00A3_0002_0001` which has a completly con feature report of 90 bytes. -Modified expected report descriptor reference file `045E_02FF_0005_0001_expected.rpt_desc` to include additional padding bytes.
Youw
reviewed
Oct 28, 2024
Co-authored-by: Ihor Dutchak <ihor.youw@gmail.com>
Member
|
If someone could test/verify this - I'll approve/merge. |
Member
|
Not sure if I have test devices which can test the improvement in this PR. Still I will check with my existing devices to see if there are any differences. |
SuibianP
approved these changes
Oct 30, 2024
SuibianP
left a comment
SuibianP
left a comment
There was a problem hiding this comment.
Tested with 1532:00A3. hid_report_reconstructor_test adds the last const report correctly.
Youw
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1532_00A3_0002_0001which has a completly con feature report of 90 bytes.045E_02FF_0005_0001_expected.rpt_descto include additional padding bytes.Closes: #703