windows: Get Bluetooth device Model Number String instead of Device Name into product string#500
Merged
Youw merged 2 commits intolibusb:masterfrom Mar 12, 2023
Merged
Conversation
…vice Name (UUID: 0x2A00) into hid_device_info.product_string. Use Device Name only if Model Number String is not available. See [Device Information Service](https://www.bluetooth.com/specifications/specs/device-information-service-1-1/) spec for more info.
Youw
reviewed
Feb 1, 2023
Contributor
Author
|
@Youw looks good. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Device Nameonly ifModel Number Stringis not available. This should better match what we have inUSB_DEVICE_DESCRIPTOR.iProductSee Bluetooth Device Information Service spec for more info.