Provide Unit Test for Issue #214 Engine.getEntitiesFor() during EntityListener.entityRemoved #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests that should recreate the issue. Original issue must be somewhere else in the project original found in.
Attempting to use up pooled entities to see if a previously pooled entity caused the issue. No luck, all good.
Issue number libgdx#214 is recreated in this new unit test if the commented line is uncommented. Line 518 in PooledEngineTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an example set of tests produced when tracking down the root cause of this issue. The test that highlights the issue is PooledEngineTests.removeDuringEntityRemovedHandledOk.
Line 518 will need to be uncommented to reproduce. I have it commented so tests pass by default at the moment.