-
Notifications
You must be signed in to change notification settings - Fork 6
ladislas/feature/mocks move ctor dtor out of class #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ladislas
wants to merge
4
commits into
develop
Choose a base branch
from
ladislas/feature/mocks-move-ctor-dtor-out-of-class
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ladislas/feature/mocks move ctor dtor out of class #1205
ladislas
wants to merge
4
commits into
develop
from
ladislas/feature/mocks-move-ctor-dtor-out-of-class
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ladislas
commented
Dec 13, 2022
- ♻️ (mocks): Move mocks ctor/dtor out of class body
- 🚧 (FIXUP): move c/dtor out of class except some classes
- ♻️ (CoreLL): Use real interface::LL, update mocks, tests
- ✅ (RFIDKit): Silence mock function unexpected call
- ✅ (CoreVideo): Cleanup mock expectation with An()
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1205 +/- ##
===========================================
- Coverage 96.21% 96.12% -0.09%
===========================================
Files 146 146
Lines 3616 3564 -52
===========================================
- Hits 3479 3426 -53
- Misses 137 138 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
7349965 to
8a05791
Compare
d8acc9a to
44767a8
Compare
44767a8 to
8fad90d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
as recommended here to speed up compilation time: https://github.com/google/googletest/blob/main/docs/gmock_cook_book.md#making-the-compilation-faster
8fad90d to
0c08713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.







