Skip to content

Fix calculator build issues on Windows #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legend-df merged 2 commits into from
Oct 14, 2025
Merged

Fix calculator build issues on Windows #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7d3d0
Fix calculator build issues on Windows
legend-df Oct 14, 2025
a3fa682
Merge branch 'codex/create-flowchart-manager' into codex/fix-flowchar…
legend-df Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/calculator/FlowchartManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <QtCore/QJsonDocument>
#include <QtCore/QJsonObject>
#include <QtCore/QJsonParseError>
#include <QtCore/QJsonValue>
#include <QtCore/QList>
#include <QtCore/QObject>
#include <QtCore/QRegularExpression>
Expand Down Expand Up @@ -523,9 +524,9 @@ bool FlowchartManager::saveFlowchart(FlowchartPage *page, bool forceSaveAs, bool
}
}

bool const saved = forceSaveAs ? page->saveAs() : page->save();
bool const wasSaved = forceSaveAs ? page->saveAs() : page->save();

if (!saved) {
if (!wasSaved) {
if (showErrorOnFailure) {
QString targetName = page->filePath().isEmpty() ? page->displayName()
: QFileInfo(page->filePath()).fileName();
Expand Down Expand Up @@ -757,7 +758,7 @@ bool FlowchartManager::loadProject(QString const &fileName)

bool anyLoaded = false;

for (QJsonValueConstRef value : charts) {
for (QJsonValue const &value : charts) {
if (!value.isObject())
continue;

Expand Down