-
Notifications
You must be signed in to change notification settings - Fork 0
Promote code from dev to prod #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `axios` to `package.json` - create problem-extractor package
- Add `problem-extractor.test.ts` file - Update `ProblemExtractor.problems` to be of type `LeetcodeProblem[]` - Update `packages/problem-extractor/interfaces.ts` to remove ProblemData interface - Add babel.config.js for jest
…ervice Feature/create problem service
- Create `/v1/problems` endpoint to get all problems - Create `src/v1/controllers/problems.ts` controller for problems - Create `src/v1/services/problems.ts` service for problems - Create `src/v1/routes/problems.ts` router for problems
- Add `mongoose` to project - Create `Problems` model - Create `src/v1/db/problems.ts` to populate problems table
…endpoint Feature/create problems endpoint
- Add `swagger-ui-express` to `package.json` - Create `swagger.v1.json` file - Add `/v1/docs` route for swagger docs
- Remove url from `contact` in `swagger.json` - Set docs to the base url
…docs Add swagger docs for v1 api
…ctor remove package-extractor from API
- add `winston` to `package.json` - Create `logger.ts` file - Update `console.log` calls to `logger.info` or `logger.error` calls
Add logger to API
- Setup `limit` and `offset` values for API
- Add `app.set('json spaces', 2)` to get formatted JSON
Feature/add pagination
- Add test to `GET /v1/problems` - Add `supertest` to `package.json` - Export `app` from `app.ts` and run server in `index.ts`
- Change mongoose database for tests to use `mongodb://localhost:27017/JestDB` - Fix issue with `npm start` in `package.json`
Create API tests
Move tests to version file
- Create `HTTPError` class to create http errors - Create `getProblemById` service and controller methods
…lem-by-id-route Feature/create get problem by id route
Add query parameters to API
Changed imports to directories in soruce code
…d-error Create `not-found` middleware
Update README.md
…-search Feature/create question search
jaredaivory
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big Review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.