fix: if statment in func. collect_completion_data() #172
Conversation
|
I'm sorry but this 'fix' doesn't make any sense to me yet and I can't confirm the initial problem. We already have this in the init function: if !exists('b:ledger_bin')
let b:ledger_bin = get(g:, 'ledger_bin', 0)
endifThe completion function should be running in an environment where the init function has already run, so the value should never not exist at all. If the user hasn't set any global preference and we haven't discovered anything useful we will at least set the buffer local value to 0. |
|
Gah, I just re-read your comment in the issue which I've ready before but somehow it didn't all click. I think the extra layer on this issues is that we are setting a value all the time, so the test for |
| let transactions = ledger#transactions() | ||
| let cache = {'descriptions': [], 'tags': {}, 'accounts': {}, 'flat_accounts': []} | ||
| if b:ledger_bin | ||
| if exists('b:ledger_bin') |
There was a problem hiding this comment.
These need to be either a test for not being 0 or being a string or something, but this is always going to exist, the trouble is that both our falsy value 0 and real values strings are testing as falsey.
2 participants
I think this may fix the #171