Skip to content

Fix remaining depend/package issues; Misc updates#237

Merged
jselstad merged 4 commits intomasterfrom
fix-migrate-phantomjs
Dec 11, 2019
Merged

Fix remaining depend/package issues; Misc updates#237
jselstad merged 4 commits intomasterfrom
fix-migrate-phantomjs

Conversation

@RecursiveCptHook
Copy link
Contributor

  • Fixes remaining security issues as per npm audit (result of old phantomjs)
  • Removed usage of phantomjs due to deprecation/archival (mocha-phantomjs info)
  • Migrated from mocha-phantomjs to mocha-chrome
  • Added ultraleap to the bower keywords
  • Updated changelog
  • Removed erroneous change from other PR that was under test in compiled leapjs

@RecursiveCptHook
Copy link
Contributor Author

Awesome, and Travis is functioning as expected now also. 👍

Copy link
Contributor

@jselstad jselstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's see if Github is going to come back with a Round 2 on the audits...

@jselstad jselstad merged commit 3d95321 into master Dec 11, 2019
@jselstad jselstad deleted the fix-migrate-phantomjs branch December 11, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants