test: add regression test for perm lemma fvar ordering #12149
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a test case guarding against a regression where `simp` incorrectly rejects valid rewrites for perm lemmas. The issue occurs when fvar ids created in async elaboration don't maintain declaration order in their `Name.lt` comparison, breaking the assumption in `acLt` that later-declared fvars compare greater. This test depends on the revert in #12148. See #12136 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case guarding against a regression where
simpincorrectly rejects valid rewrites for perm lemmas.The issue occurs when fvar ids created in async elaboration don't maintain declaration order in their
Name.ltcomparison, breaking the assumption inacLtthat later-declared fvars compare greater.The test is based on a minimal reproduction from @Rob23oba in #12136.
Depends on: #12148
See #12136
🤖 Prepared with Claude Code