Skip to content

Conversation

@grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 10, 2026

Found by extending the whitespace linter to proof bodies in #30658.
Also alphabetise the linter options in Mathlib.Init.


Open in Gitpod

Found by extending the whitespace linter to proof bodies in leanprover-community#30658.
-- we may want to put them in a more specific scope.
@[inherit_doc ContDiffMapSupportedIn.seminorm]
scoped[Distributions] notation "N[" 𝕜 "]_{" K "," n "," i "}" =>
scoped[Distributions] notation "N[" 𝕜 "]_{" K ", " n ", " i "}" =>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change matches every single usage in the file: the pretty-printing was simply wrong.

@grunweg grunweg requested a review from adomani January 10, 2026 09:18
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

PR summary 64b271788f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll leave you to choose whether to accept the suggestion.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 10, 2026

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 10, 2026
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 10, 2026

Thanks for the suggestion, good call!
bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 10, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 10, 2026
Found by extending the whitespace linter to proof bodies in #30658.
Also alphabetise the linter options in `Mathlib.Init`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 10, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title style: whitespace fixes [Merged by Bors] - style: whitespace fixes Jan 10, 2026
@mathlib-bors mathlib-bors bot closed this Jan 10, 2026
@grunweg grunweg deleted the whitespace-onemore branch January 10, 2026 18:56
@adomani adomani mentioned this pull request Jan 16, 2026
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
Found by extending the whitespace linter to proof bodies in leanprover-community#30658.
Also alphabetise the linter options in `Mathlib.Init`.
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Found by extending the whitespace linter to proof bodies in leanprover-community#30658.
Also alphabetise the linter options in `Mathlib.Init`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants