[Merged by Bors] - feat(RingTheory/Localization/Ideal): generalize comap_map_of_isPrime_disjoint to primary ideals
#33806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tb65536
added
awaiting-CI
PR summary 81dc80b163
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Localization.Ideal | 1121 | 1123 | +2 (+0.18%) |
Import changes for all files
| Files | Import difference |
|---|---|
8 filesMathlib.RingTheory.Conductor Mathlib.RingTheory.FractionalIdeal.Basic Mathlib.RingTheory.FractionalIdeal.Inverse Mathlib.RingTheory.FractionalIdeal.Operations Mathlib.RingTheory.Localization.Algebra Mathlib.RingTheory.Localization.Away.Lemmas Mathlib.RingTheory.Localization.Ideal Mathlib.RingTheory.Localization.Submodule |
2 |
Declarations diff
+ comap_map_of_isPrimary_disjoint
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
bot
removed
the
awaiting-CI
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
leanprover-community-mathlib4-bot
added
the
maintainer-merge
Contributor
|
✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…_disjoint` to primary ideals (#33806) This PR generalizes `comap_map_of_isPrime_disjoint` to primary ideals, but keeps the existing statement around since it seems to be getting the most use in practice. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…_disjoint` to primary ideals (#33806) This PR generalizes `comap_map_of_isPrime_disjoint` to primary ideals, but keeps the existing statement around since it seems to be getting the most use in practice. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
comap_map_of_isPrime_disjoint to primary idealscomap_map_of_isPrime_disjoint to primary ideals
eliasjudin
pushed a commit
to eliasjudin/mathlib4
that referenced
this pull request
Jan 18, 2026
…_disjoint` to primary ideals (leanprover-community#33806) This PR generalizes `comap_map_of_isPrime_disjoint` to primary ideals, but keeps the existing statement around since it seems to be getting the most use in practice. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…_disjoint` to primary ideals (leanprover-community#33806) This PR generalizes `comap_map_of_isPrime_disjoint` to primary ideals, but keeps the existing statement around since it seems to be getting the most use in practice. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes
comap_map_of_isPrime_disjointto primary ideals, but keeps the existing statement around since it seems to be getting the most use in practice.