[Merged by Bors] - feat(Ideal/IsPrimary): Ideal.isPrimary preserved by Ideal.comap
#33781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tb65536
added
awaiting-author
PR summary ee6d0f13b3
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Ideal.IsPrimary | 842 | 845 | +3 (+0.36%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Ideal.IsPrimary |
3 |
Declarations diff
+ IsPrimary.comap
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
bot
removed
the
awaiting-CI
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
leanprover-community-mathlib4-bot
added
the
maintainer-merge
Member
|
Thanks! bors merge |
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
…33781) This PR adds a lemma stating that the preimage of a primary ideal under a ring homomorphism remains a primary ideal. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Ideal.isPrimary preserved by Ideal.comapIdeal.isPrimary preserved by Ideal.comap
eliasjudin
pushed a commit
to eliasjudin/mathlib4
that referenced
this pull request
Jan 18, 2026
…eanprover-community#33781) This PR adds a lemma stating that the preimage of a primary ideal under a ring homomorphism remains a primary ideal. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…eanprover-community#33781) This PR adds a lemma stating that the preimage of a primary ideal under a ring homomorphism remains a primary ideal. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lemma stating that the preimage of a primary ideal under a ring homomorphism remains a primary ideal.