[Merged by Bors] - feat(translate): linter for overwriting existing translations #33777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 21cf59b03bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
|
This pull request has conflicts, please merge |
mathlib4-merge-conflict-bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
2 tasks
| if tgt != tgt' then | ||
| Linter.logLintIf linter.translateOverwrite ref | ||
| m!"`{src}` was already translated to `{tgt'}` instead of `{tgt}`.\n\ | ||
| Unless the original translation was wrong, please remove this `{t.attrName}` attribute." |
Contributor
There was a problem hiding this comment.
We don't have a test that shows this new warning in action, right?
Collaborator
Author
There was a problem hiding this comment.
I've added one now
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
This PR refactors the linter in `to_dual`/`to_additive` for when you tag a declaration that already has a translation. Previously it threw an error that couldn't be turned off, and it would only do this when using the `existing` modifier. Now it also runs without the `existing` modifier, and it only throws a warning, which can also be turned off. There was some hard coded stuff for allowing to correct the `(reorder := ...)` argument. I removed this code, which also has the side effect of making the syntax more consistent. In order to stay compatible with these cases, the linter doesn't complain when setting the translation to the same thing again. See also #1779 which allowed `to_additive` on already existing translations
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
eliasjudin
pushed a commit
to eliasjudin/mathlib4
that referenced
this pull request
Jan 18, 2026
…over-community#33777) This PR refactors the linter in `to_dual`/`to_additive` for when you tag a declaration that already has a translation. Previously it threw an error that couldn't be turned off, and it would only do this when using the `existing` modifier. Now it also runs without the `existing` modifier, and it only throws a warning, which can also be turned off. There was some hard coded stuff for allowing to correct the `(reorder := ...)` argument. I removed this code, which also has the side effect of making the syntax more consistent. In order to stay compatible with these cases, the linter doesn't complain when setting the translation to the same thing again. See also leanprover-community#1779 which allowed `to_additive` on already existing translations
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…over-community#33777) This PR refactors the linter in `to_dual`/`to_additive` for when you tag a declaration that already has a translation. Previously it threw an error that couldn't be turned off, and it would only do this when using the `existing` modifier. Now it also runs without the `existing` modifier, and it only throws a warning, which can also be turned off. There was some hard coded stuff for allowing to correct the `(reorder := ...)` argument. I removed this code, which also has the side effect of making the syntax more consistent. In order to stay compatible with these cases, the linter doesn't complain when setting the translation to the same thing again. See also leanprover-community#1779 which allowed `to_additive` on already existing translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the linter in
to_dual/to_additivefor when you tag a declaration that already has a translation. Previously it threw an error that couldn't be turned off, and it would only do this when using theexistingmodifier. Now it also runs without theexistingmodifier, and it only throws a warning, which can also be turned off.There was some hard coded stuff for allowing to correct the
(reorder := ...)argument. I removed this code, which also has the side effect of making the syntax more consistent. In order to stay compatible with these cases, the linter doesn't complain when setting the translation to the same thing again.See also #1779 which allowed
to_additiveon already existing translations