Skip to content

Conversation

@bryangingechen
Copy link
Contributor

The needs context returns overall status for the matrix rather than the status for the specific matrix entry.

Prepared with Claude


Open in Gitpod

The needs context returns overall status for the matrix rather than the status for the specific matrix entry.

Prepared with Claude
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

PR summary d07aaeafc7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Jan 8, 2026
Copy link
Contributor

@kim-em kim-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recording links to two places this has happened recently.

@kim-em
Copy link
Contributor

kim-em commented Jan 8, 2026

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 8, 2026

✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 8, 2026
@bryangingechen
Copy link
Contributor Author

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 8, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 8, 2026
…33738)

The needs context returns overall status for the matrix rather than the status for the specific matrix entry.

Prepared with Claude
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 8, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title ci(daily.yml): get job status from API instead of via needs context [Merged by Bors] - ci(daily.yml): get job status from API instead of via needs context Jan 8, 2026
@mathlib-bors mathlib-bors bot closed this Jan 8, 2026
@mathlib-bors mathlib-bors bot deleted the bryangingechen-patch-1 branch January 8, 2026 03:36
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…eanprover-community#33738)

The needs context returns overall status for the matrix rather than the status for the specific matrix entry.

Prepared with Claude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants