Skip to content

Conversation

@harahu
Copy link
Contributor

@harahu harahu commented Jan 7, 2026

Found by extending the commandStart linter to proof bodies in #30658.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

PR summary 667d6f2c88

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Collaborator

grunweg commented Jan 7, 2026

Can you adjust the PR description (as I did for your other two PRs a moment ago) and fix the one comment, please?
Assuming CI passes then, feel free to merge yourself:
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

✌️ harahu can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg grunweg self-assigned this Jan 7, 2026
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 7, 2026
@grunweg grunweg changed the title chore(misc): fix white space style(misc): fix whitespace Jan 7, 2026
@harahu
Copy link
Contributor Author

harahu commented Jan 7, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 7, 2026
Found by extending the commandStart linter to proof bodies in #30658.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title style(misc): fix whitespace [Merged by Bors] - style(misc): fix whitespace Jan 7, 2026
@mathlib-bors mathlib-bors bot closed this Jan 7, 2026
@harahu harahu deleted the chore/fw-data branch January 8, 2026 07:19
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Found by extending the commandStart linter to proof bodies in leanprover-community#30658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants