Skip to content

Conversation

@tydeu
Copy link
Collaborator

@tydeu tydeu commented Jan 6, 2026

Fixes a typo in the code for printing the output of failed lake build of the ProofWidgets fetch in lake exe cache. It will no properly print stdout rather than stderr under the lake stdout: heading.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PR summary e86c41d96c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kim-em
Copy link
Contributor

kim-em commented Jan 6, 2026

CI failure is unrelated to this PR - it was caused by the same issue fixed in #33646. A rerun should pass now that the workflow is fixed.

@kim-em
Copy link
Contributor

kim-em commented Jan 6, 2026

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 6, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 6, 2026
Fixes a typo in the code for printing the output of failed `lake build` of the ProofWidgets fetch in `lake exe cache`. It will no properly print stdout rather than stderr under the `lake stdout:` heading.

Co-authored-by: Kim Morrison <kim@tqft.net>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Cache): print ProofWidgets build stdout on error [Merged by Bors] - fix(Cache): print ProofWidgets build stdout on error Jan 6, 2026
@mathlib-bors mathlib-bors bot closed this Jan 6, 2026
@tydeu tydeu deleted the print-stdout branch January 6, 2026 08:07
kim-em added a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
…unity#33651)

Fixes a typo in the code for printing the output of failed `lake build` of the ProofWidgets fetch in `lake exe cache`. It will no properly print stdout rather than stderr under the `lake stdout:` heading.

Co-authored-by: Kim Morrison <kim@tqft.net>
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…unity#33651)

Fixes a typo in the code for printing the output of failed `lake build` of the ProofWidgets fetch in `lake exe cache`. It will no properly print stdout rather than stderr under the `lake stdout:` heading.

Co-authored-by: Kim Morrison <kim@tqft.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants