[Merged by Bors] - refactor: Ideal.bot_prime as an instance

[xgenereux]

---

[github-actions]

PR summary 27ab765809

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff

+ instance : P.support.IsPrime := by simpa using Ideal.isPrime_bot
+ isPrime_bot
- instance : P.support.IsPrime := by simpa using Ideal.bot_prime

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

---

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[xgenereux]

!bench

[leanprover-radar]

Benchmark results for f401614 against 27ab765 are in! @xgenereux

Large changes (1✅)

• ✅ open-mathlib//wall-clock: -423ms (-6.6%)

Small changes (1🟥)

• 🟥 build/module/Mathlib.Util.LongNames//instructions: +129.0M (+4.2%)

[xgenereux]

Given the bench, would it be fine to have this as an instance?

[alreadydone]

!radar (oh it's already been benched)

[erdOne]

maintainer delegate

[github-actions]

🚀 Pull request has been placed on the maintainer queue by erdOne.

[riccardobrasca]

!bench

[leanprover-radar]

Benchmark results for 7241087 against 27ab765 are in! @riccardobrasca

Large changes (1✅)

• ✅ open-mathlib//wall-clock: -391ms (-6.1%)

Small changes (4✅, 1🟥)

• ✅ build/module/Mathlib.Data.Int.LeastGreatest//instructions: -230.0M (-3.7%)
• ✅ build/module/Mathlib.RingTheory.WittVector.InitTail//instructions: -739.6M (-2.6%)
• ✅ build/module/Mathlib.RingTheory.WittVector.MulP//instructions: -693.0M (-5.3%)
• ✅ build/module/Mathlib.RingTheory.WittVector.Verschiebung//instructions: -680.1M (-4.6%)
• 🟥 build/module/Mathlib.Util.LongNames//instructions: +128.1M (+4.2%)

[erdOne]

It was already benched and it seemed fine. But I guess it doesn't hurt to check again.

[riccardobrasca]

Oh sorry, I didn't notice it. Anyway we are still missing a deprecation.

bors d+

[mathlib-bors]

✌️ xgenereux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[xgenereux]

bors r+

[mathlib-bors]

Pull request successfully merged into master.

Build succeeded:

• Build
• Lint style
• Post-Build Step