[Merged by Bors] - chore: golf proofs #33600
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective.
Trace profiling results (shown if ≥10 ms before or after):
LinearIsometry.extend_apply: 159 ms before, 109 ms after 🎉Submodule.finrank_add_inf_finrank_orthogonal: 219 ms before, 193 ms after 🎉maximal_orthonormal_iff_basis_of_finiteDimensional: 100 ms before, 58 ms after 🎉Field.primitive_element_iff_algHom_eq_of_eval: 508 ms before, 460 ms after 🎉Field.finSepDegree_eq: 118 ms before, 89 ms after 🎉IntermediateField.adjoin_eq_adjoin_pow_expChar_pow_of_isSeparable: 638 ms before, 611 ms after 🎉IntermediateField.adjoin_simple_eq_adjoin_pow_expChar_pow_of_isSeparable': 57 ms before, <10 ms after 🎉LinearIndependent.map_pow_expChar_pow_of_isSeparable: 314 ms before, 268 ms after 🎉IntermediateField.rank_bot_mul_relrank: 775 ms before, 686 ms after 🎉EuclideanGeometry.exists_circumradius_eq_of_cospherical: 63 ms before, 41 ms after 🎉EuclideanGeometry.exists_circumcenter_eq_of_cospherical: 63 ms before, 41 ms after 🎉EuclideanGeometry.exists_circumsphere_eq_of_cospherical: 64 ms before, 43 ms after 🎉Submodule.natAbs_det_equiv: 653 ms before, 587 ms after 🎉Matrix.rank_le_card_width: 65 ms before, 16 ms after 🎉Matrix.rank_le_card_height: 80 ms before, 12 ms after 🎉LinearMap.BilinForm.exists_orthogonal_basis: 606 ms before, 581 ms after 🎉RingOfIntegers.isUnit_norm: 654 ms before, 584 ms after 🎉This golfing PR is batched under the following guidelines: