Skip to content

Conversation

@JovanGerb
Copy link
Collaborator

This PR removes privateInPublic and private from all lemmas used by the positivity tactic. These lemmas are part of the public API of the positivity tactic, so it makes sense for the lemmas to be public. They all live in the Mathlib.Meta.Positivity namespace, so they can't be confused with user-facing lemmas.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

PR summary eae0ea4f18

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ NNRat.num_ne_zero_of_ne_zero
+ NNRat.num_pos_of_pos
+ abs_pos_of_ne_zero
+ div_ne_zero_of_ne_zero_of_pos
+ div_ne_zero_of_pos_of_ne_zero
+ div_nonneg_of_nonneg_of_pos
+ div_nonneg_of_pos_of_nonneg
+ int_ceil_pos
+ int_div_nonneg_of_nonneg_of_pos
+ int_div_nonneg_of_pos_of_nonneg
+ int_div_nonneg_of_pos_of_pos
+ int_div_self_pos
+ int_floor_nonneg
+ int_floor_nonneg_of_pos
+ int_natAbs_pos
+ ite_ne_zero
+ ite_ne_zero_of_ne_zero_of_pos
+ ite_ne_zero_of_pos_of_ne_zero
+ ite_nonneg
+ ite_nonneg_of_nonneg_of_pos
+ ite_nonneg_of_pos_of_nonneg
+ ite_pos
+ le_min_of_le_of_lt
+ le_min_of_lt_of_le
+ max_ne
+ min_ne
+ min_ne_of_lt_of_ne
+ min_ne_of_ne_of_lt
+ natCeil_pos
+ nat_ceil_pos
+ nnabs_pos_of_pos
+ nnreal_coe_pos
+ num_ne_zero_of_ne_zero
+ num_nonneg_of_nonneg
+ num_pos_of_pos
+ ofReal_ne_zero_of_ne_zero
+ ofReal_nonneg
+ ofReal_pos
+ pow_zero_pos
+ prod_ne_zero
+ sinh_ne_zero_of_ne_zero
+ sinh_nonneg_of_nonneg
+ sinh_pos_of_pos
+ smul_ne_zero_of_ne_zero_of_pos
+ smul_ne_zero_of_pos_of_ne_zero
+ smul_nonneg_of_nonneg_of_pos
+ smul_nonneg_of_pos_of_nonneg
+ smul_nonneg_of_pos_of_pos
+ zpow_zero_pos

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (50.00, 0.07)
Current number Change Type
1438 -50 backwards compatibility flags
1410 -50 privateInPublic flags

Current commit 11d7a1af46
Reference commit eae0ea4f18

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 5, 2026
This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 5, 2026

This PR was included in a batch that timed out, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Jan 5, 2026
This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(positivity): make tactic lemmas public [Merged by Bors] - chore(positivity): make tactic lemmas public Jan 5, 2026
@mathlib-bors mathlib-bors bot closed this Jan 5, 2026
xgenereux pushed a commit to xgenereux/mathlib4 that referenced this pull request Jan 5, 2026
)

This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
)

This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
)

This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants