-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - chore(positivity): make tactic lemmas public #33593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(positivity): make tactic lemmas public #33593
Conversation
PR summary eae0ea4f18Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 1438 | -50 | backwards compatibility flags |
| 1410 | -50 | privateInPublic flags |
Current commit 11d7a1af46
Reference commit eae0ea4f18
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Thanks 🎉 bors merge |
This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
|
This PR was included in a batch that timed out, it will be automatically retried |
This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
|
Pull request successfully merged into master. Build succeeded: |
) This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
) This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
) This PR removes `privateInPublic` and `private` from all lemmas used by the `positivity` tactic. These lemmas are part of the public API of the `positivity` tactic, so it makes sense for the lemmas to be public. They all live in the `Mathlib.Meta.Positivity` namespace, so they can't be confused with user-facing lemmas.
This PR removes
privateInPublicandprivatefrom all lemmas used by thepositivitytactic. These lemmas are part of the public API of thepositivitytactic, so it makes sense for the lemmas to be public. They all live in theMathlib.Meta.Positivitynamespace, so they can't be confused with user-facing lemmas.