Skip to content

Conversation

@urkud
Copy link
Member

@urkud urkud commented Jan 3, 2026

We have a closedBall version, add an open ball version too.


Open in Gitpod

We have a `closedBall` version, add an open ball version too.
@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jan 3, 2026
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

PR summary aa4187fed5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eventually_ball_subset

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@sgouezel
Copy link
Contributor

sgouezel commented Jan 3, 2026

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 3, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 3, 2026
We have a `closedBall` version, add an open ball version too.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 3, 2026

Timed out.

@sgouezel
Copy link
Contributor

sgouezel commented Jan 3, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 3, 2026
We have a `closedBall` version, add an open ball version too.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 3, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(MetricSpace): add eventually_ball_subset [Merged by Bors] - feat(MetricSpace): add eventually_ball_subset Jan 3, 2026
@mathlib-bors mathlib-bors bot closed this Jan 3, 2026
@urkud urkud deleted the ev-ball-subset branch January 4, 2026 03:19
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
…#33512)

We have a `closedBall` version, add an open ball version too.
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…#33512)

We have a `closedBall` version, add an open ball version too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants