Skip to content

Conversation

@erdOne
Copy link
Member

@erdOne erdOne commented Jan 1, 2026


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

PR summary 98d019b66b

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Polynomial.IsIntegral 1398 1370 -28 (-2.00%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Polynomial.IsIntegral -28

Declarations diff

+ IsIntegral.coeff
+ IsIntegral.of_aeval_monic_of_isIntegral_coeff
+ IsRoot.dvd_coeff_zero
+ MvPolynomial.isIntegral_iff_isIntegral_coeff.{w}
+ Polynomial.Monic.exists_splits_map.{u}
+ Polynomial.isIntegral_iff_isIntegral_coeff
+ RingHom.IsIntegralElem.map
+ RingHom.IsIntegralElem.map_iff
+ RingHom.IsIntegralElem.of_comp
+ RingHom.IsIntegralElem.of_map
+ killCompl_map
+ optionEquivLeft_symm_C_C
+ optionEquivLeft_symm_X

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 2, 2026
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 2, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 2, 2026

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): polynomial is integral <-> coeffs are integral [Merged by Bors] - feat(RingTheory): polynomial is integral <-> coeffs are integral Jan 2, 2026
@mathlib-bors mathlib-bors bot closed this Jan 2, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants