-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - feat(RingTheory): polynomial is integral <-> coeffs are integral #33468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erdOne
commented
Jan 1, 2026
PR summary 98d019b66b
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Polynomial.IsIntegral | 1398 | 1370 | -28 (-2.00%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Polynomial.IsIntegral |
-28 |
Declarations diff
+ IsIntegral.coeff
+ IsIntegral.of_aeval_monic_of_isIntegral_coeff
+ IsRoot.dvd_coeff_zero
+ MvPolynomial.isIntegral_iff_isIntegral_coeff.{w}
+ Polynomial.Monic.exists_splits_map.{u}
+ Polynomial.isIntegral_iff_isIntegral_coeff
+ RingHom.IsIntegralElem.map
+ RingHom.IsIntegralElem.map_iff
+ RingHom.IsIntegralElem.of_comp
+ RingHom.IsIntegralElem.of_map
+ killCompl_map
+ optionEquivLeft_symm_C_C
+ optionEquivLeft_symm_X
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
riccardobrasca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors merge
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |