Skip to content

Conversation

@urkud
Copy link
Member

@urkud urkud commented Dec 31, 2025

Cherry-picked from #33423, then added more lemmas as requested by @eric-wieser


Open in Gitpod

feat(ToIntervalMod): add missing lemmas

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

PR summary 73fe7bad3e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ExistsUnique.choose_eq_iff
+ self_sub_toIcoDiv_mul
+ self_sub_toIcoMod_eq_mul
+ self_sub_toIocDiv_mul
+ self_sub_toIocMod_eq_mul
+ toIcoDiv_add_intCast_mul
+ toIcoDiv_add_intCast_mul'
+ toIcoDiv_add_natCast_mul
+ toIcoDiv_add_natCast_mul'
+ toIcoDiv_add_nsmul
+ toIcoDiv_add_nsmul'
+ toIcoDiv_add_ofNat_mul
+ toIcoDiv_add_ofNat_mul'
+ toIcoDiv_eq_iff
+ toIcoDiv_intCast_mul_add
+ toIcoDiv_mul_sub_self
+ toIcoDiv_mul_sub_toIcoMod
+ toIcoDiv_natCast_mul_add
+ toIcoDiv_nsmul_add
+ toIcoDiv_ofNat_mul_add
+ toIcoDiv_sub_intCast_mul
+ toIcoDiv_sub_intCast_mul'
+ toIcoDiv_sub_natCast_mul
+ toIcoDiv_sub_natCast_mul'
+ toIcoDiv_sub_nsmul
+ toIcoDiv_sub_nsmul'
+ toIcoDiv_sub_ofNat_mul
+ toIcoDiv_sub_ofNat_mul'
+ toIcoMod_add_intCast_mul
+ toIcoMod_add_intCast_mul'
+ toIcoMod_add_natCast_mul
+ toIcoMod_add_natCast_mul'
+ toIcoMod_add_nsmul
+ toIcoMod_add_nsmul'
+ toIcoMod_add_ofNat_mul
+ toIcoMod_add_ofNat_mul'
+ toIcoMod_add_toIcoDiv_mul
+ toIcoMod_intCast_mul_add
+ toIcoMod_intCast_mul_add'
+ toIcoMod_natCast_mul_add
+ toIcoMod_natCast_mul_add'
+ toIcoMod_nsmul_add
+ toIcoMod_nsmul_add'
+ toIcoMod_ofNat_mul_add
+ toIcoMod_ofNat_mul_add'
+ toIcoMod_sub_intCast_mul
+ toIcoMod_sub_intCast_mul'
+ toIcoMod_sub_natCast_mul
+ toIcoMod_sub_natCast_mul'
+ toIcoMod_sub_nsmul
+ toIcoMod_sub_nsmul'
+ toIcoMod_sub_ofNat_mul
+ toIcoMod_sub_ofNat_mul'
+ toIcoMod_sub_self_eq_mul
+ toIocDiv_add_intCast_mul
+ toIocDiv_add_intCast_mul'
+ toIocDiv_add_natCast_mul
+ toIocDiv_add_natCast_mul'
+ toIocDiv_add_nsmul
+ toIocDiv_add_nsmul'
+ toIocDiv_add_ofNat_mul
+ toIocDiv_add_ofNat_mul'
+ toIocDiv_eq_iff
+ toIocDiv_intCast_mul_add
+ toIocDiv_mul_sub_self
+ toIocDiv_mul_sub_toIocMod
+ toIocDiv_natCast_mul_add
+ toIocDiv_nsmul_add
+ toIocDiv_ofNat_mul_add
+ toIocDiv_sub_intCast_mul
+ toIocDiv_sub_intCast_mul'
+ toIocDiv_sub_natCast_mul
+ toIocDiv_sub_natCast_mul'
+ toIocDiv_sub_nsmul
+ toIocDiv_sub_nsmul'
+ toIocDiv_sub_ofNat_mul
+ toIocDiv_sub_ofNat_mul'
+ toIocMod_add_intCast_mul
+ toIocMod_add_intCast_mul'
+ toIocMod_add_natCast_mul
+ toIocMod_add_natCast_mul'
+ toIocMod_add_nsmul
+ toIocMod_add_nsmul'
+ toIocMod_add_ofNat_mul
+ toIocMod_add_ofNat_mul'
+ toIocMod_add_toIocDiv_mul
+ toIocMod_intCast_mul_add
+ toIocMod_intCast_mul_add'
+ toIocMod_natCast_mul_add
+ toIocMod_natCast_mul_add'
+ toIocMod_nsmul_add
+ toIocMod_nsmul_add'
+ toIocMod_ofNat_mul_add
+ toIocMod_ofNat_mul_add'
+ toIocMod_sub_intCast_mul
+ toIocMod_sub_intCast_mul'
+ toIocMod_sub_natCast_mul
+ toIocMod_sub_natCast_mul'
+ toIocMod_sub_nsmul
+ toIocMod_sub_nsmul'
+ toIocMod_sub_ofNat_mul
+ toIocMod_sub_ofNat_mul'
+ toIocMod_sub_self_eq_mul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@urkud urkud requested a review from eric-wieser December 31, 2025 20:10
@eric-wieser
Copy link
Member

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 1, 2026

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 1, 2026
@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jan 3, 2026
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 3, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 3, 2026
Cherry-picked from #33423, then added more lemmas as requested by @eric-wieser
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 3, 2026

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 3, 2026
Cherry-picked from #33423, then added more lemmas as requested by @eric-wieser
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 3, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(ToIntervalMod): add missing lemmas [Merged by Bors] - feat(ToIntervalMod): add missing lemmas Jan 3, 2026
@mathlib-bors mathlib-bors bot closed this Jan 3, 2026
@urkud urkud deleted the toIxxMod-lemmas branch January 4, 2026 03:19
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants