Skip to content

Conversation

@peakpoint
Copy link
Collaborator


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

PR summary a637594054

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.Separation.NotNormal 1423 661 -762 (-53.55%)
Import changes for all files
Files Import difference
Mathlib.Topology.Separation.NotNormal -762

Declarations diff

+ mk_lt_continuum
+ mk_lt_two_pow_mk_dense
+ not_normal_of_continuum_le_mk
+ two_pow_mk_le_two_pow_mk_dense
+ two_pow_mk_lt_continuum
- IsClosed.mk_lt_continuum
- IsClosed.not_normal_of_continuum_le_mk

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 30, 2025
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One optional suggestion to trim some lemmas.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 5, 2026

✌️ peakpoint can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 5, 2026
@peakpoint
Copy link
Collaborator Author

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Separation/NotNormal): generalize to non-separable spaces [Merged by Bors] - feat(Topology/Separation/NotNormal): generalize to non-separable spaces Jan 6, 2026
@mathlib-bors mathlib-bors bot closed this Jan 6, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants