Skip to content

Conversation

@CoolRmal
Copy link
Contributor


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Dec 26, 2025
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

PR summary d68c4dc09f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Set.Finite.dense_sInter
+ baire_of_finite

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 26, 2025
@CoolRmal CoolRmal changed the title feat: a finite set is Baire. feat: a finite space is Baire. Dec 26, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 27, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Dec 27, 2025
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want this? It seems an odd thing to care about whether a finite space is Baire.

Nevertheless, the first lemma is nice.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
CoolRmal and others added 2 commits December 31, 2025 15:22
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@CoolRmal
Copy link
Contributor Author

@j-loreaux It is just a random fact I saw on wikipedia and I found it easy to formalize. It is totally fine if you don't think it worth to be put into Mathlib.

@CoolRmal
Copy link
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 31, 2025
@j-loreaux
Copy link
Collaborator

Make it a theorem instead of an instance and we'll call it good.

@CoolRmal
Copy link
Contributor Author

CoolRmal commented Jan 1, 2026

@j-loreaux It is indeed a theorem right now.

@j-loreaux
Copy link
Collaborator

Oh, oops! Sorry.

@j-loreaux
Copy link
Collaborator

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 2, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 2, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 2, 2026

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat: a finite space is Baire. [Merged by Bors] - feat: a finite space is Baire. Jan 2, 2026
@mathlib-bors mathlib-bors bot closed this Jan 2, 2026
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants