Skip to content

Conversation

@gasparattila
Copy link
Contributor

Some of these generalizations will be useful for showing the completeness of TopologicalSpace.Compacts in a non-metrizable setting.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

PR summary 4458a06c94

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Filter.HasBasis.filter_totallyBounded_iff
+ Filter.TotallyBounded
+ Filter.TotallyBounded.exists_clusterPt
+ Filter.TotallyBounded.exists_subset_of_mem
+ Filter.TotallyBounded.isCompact_setOf_clusterPt
+ Filter.TotallyBounded.map
+ Filter.TotallyBounded.mono
+ Filter.TotallyBounded.sup
+ Filter.TotallyBounded.totallyBounded_setOf_clusterPt
+ Filter.totallyBounded_biSup
+ Filter.totallyBounded_bot
+ Filter.totallyBounded_comap
+ Filter.totallyBounded_iSup
+ Filter.totallyBounded_iff_filter
+ Filter.totallyBounded_iff_ultrafilter
+ Filter.totallyBounded_map_iff
+ Filter.totallyBounded_principal_iff
+ Filter.totallyBounded_sup
+ Ultrafilter.cauchy_of_totallyBounded'
+ image_eq_biUnion
+ preimage_eq_biUnion
+ totallyBounded_sSup

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 20, 2025
@j-loreaux
Copy link
Collaborator

Thanks! This PR was quite well-done!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 13, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 13, 2026
…33128)

Some of these generalizations will be useful for showing the completeness of `TopologicalSpace.Compacts` in a non-metrizable setting.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/UniformSpace): generalize TotallyBounded to filters [Merged by Bors] - feat(Topology/UniformSpace): generalize TotallyBounded to filters Jan 14, 2026
@mathlib-bors mathlib-bors bot closed this Jan 14, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
…eanprover-community#33128)

Some of these generalizations will be useful for showing the completeness of `TopologicalSpace.Compacts` in a non-metrizable setting.
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…eanprover-community#33128)

Some of these generalizations will be useful for showing the completeness of `TopologicalSpace.Compacts` in a non-metrizable setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants