-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - feat: define Metric.Snowflaking
#33114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 05f342bfceImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 18 | 1 | disabled simpNF lints |
Current commit 81ad12ffb6
Reference commit 05f342bfce
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Before jumping into the bulk of this PR, which I will do tomorrow, let me bikeshed a bit. I think I would prefer At the very least, we should mention snowflaking in the module documentation and docstring somewhere. |
|
It's definitely a gap in my education :-(. I've just reinvented this wheel, because the balls were of a wrong shape. I'll definitely rename it tomorrow. Could you please add more motivation to the module docstring? |
j-loreaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, aside from the naming issue, I think this is fine. I'll note a few things:
- My claim about the bilipschitz embedding of snowflaked versions of doubling metric measure spaces is Proposition 2.6 in https://www.numdam.org/article/BSMF_1983__111__429_0.pdf by Assouad. Technically, 2.6 is only one of the implications, but the other is easier and is mentioned higher up in that section of the paper.
- A standard reference in geometric measure theory that references snowflaking is Juha Heinonen's Lectures on Analysis on Metric Spaces. The beginning of Chapter 12 contains the definition.
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…o withrpow-dist
The paper talks about metric spaces of finite metric dimension. Is it the same? |
Yes, that's the one I meant. Sorry I forgot the hypothesis about finite metric dimension. |
j-loreaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the reference to either Assouad or Heinonen that I mention here? I'm fine with either or both. Otherwise, LGTM.
bors d+
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
|
This needs to go in our bibliography: @book {heinonen2001,
AUTHOR = {Heinonen, Juha},
TITLE = {Lectures on analysis on metric spaces},
SERIES = {Universitext},
PUBLISHER = {Springer-Verlag, New York},
YEAR = {2001},
PAGES = {x+140},
ISBN = {0-387-95104-0},
MRCLASS = {30C65 (28A75 28A78 46E35)},
MRNUMBER = {1800917},
MRREVIEWER = {Christopher\ Bishop},
DOI = {10.1007/978-1-4613-0131-8},
URL = {https://doi.org/10.1007/978-1-4613-0131-8},
} |
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
|
bors merge |
From https://github.com/urkud/SardMoreira This is a copy of the original space with distance redefined to be `d x y = (dist x y) ^ α`.
|
Pull request successfully merged into master. Build succeeded: |
Metric.SnowflakingMetric.Snowflaking
From https://github.com/urkud/SardMoreira This is a copy of the original space with distance redefined to be `d x y = (dist x y) ^ α`.
From https://github.com/urkud/SardMoreira This is a copy of the original space with distance redefined to be `d x y = (dist x y) ^ α`.
From https://github.com/urkud/SardMoreira This is a copy of the original space with distance redefined to be `d x y = (dist x y) ^ α`.
From https://github.com/urkud/SardMoreira
This is a copy of the original space with distance redefined to be
d x y = (dist x y) ^ α.