Skip to content

Conversation

@erdOne
Copy link
Member

@erdOne erdOne commented Dec 12, 2025


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

PR summary c1d772d632

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.ZariskisMainTheorem (new file) 1526

Declarations diff

+ ZariskisMainProperty
+ ZariskisMainProperty.of_isIntegral
+ ZariskisMainProperty.restrictScalars
+ ZariskisMainProperty.trans
+ awayMap_injective_iff
+ awayMap_surjective_iff
+ le_saturation
+ map_injective_iff
+ map_surjective_iff
+ mem_saturation_iff
+ mem_saturation_of_mul_mem_left
+ mem_saturation_of_mul_mem_right
+ saturation
+ saturation_saturation
+ zariskisMainProperty_iff
+ zariskisMainProperty_iff'
+ zariskisMainProperty_iff_exists_saturation_eq_top

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@erdOne erdOne force-pushed the erd1/zariskimainproperty branch from 4558ab8 to 5571ece Compare December 12, 2025 19:51
@erdOne erdOne added t-ring-theory Ring theory and removed Mathlib/CFT labels Dec 12, 2025
@erdOne erdOne changed the title Erd1/zariskimainproperty @erdOne feat(RingTheory): predicate on satisfying Zariski's main theorem Dec 12, 2025
@erdOne erdOne changed the title @erdOne feat(RingTheory): predicate on satisfying Zariski's main theorem feat(RingTheory): predicate on satisfying Zariski's main theorem Dec 12, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 14, 2025
@erdOne erdOne added awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Dec 14, 2025
@github-actions github-actions bot removed the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Dec 14, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 15, 2025
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 15, 2025
@erdOne erdOne requested a review from joelriou January 7, 2026 17:23
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 12, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 12, 2026

Timed out.

@joelriou
Copy link
Collaborator

Retrying...

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 12, 2026

Canceled.

@erdOne
Copy link
Member Author

erdOne commented Jan 12, 2026

I just merged master. Hopefully it will work better.
Might need to re-bors though.

@bryangingechen
Copy link
Contributor

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 13, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): predicate on satisfying Zariski's main theorem [Merged by Bors] - feat(RingTheory): predicate on satisfying Zariski's main theorem Jan 13, 2026
@mathlib-bors mathlib-bors bot closed this Jan 13, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants