Skip to content

Conversation

@erdOne
Copy link
Member

@erdOne erdOne commented Dec 12, 2025


Open in Gitpod

@github-actions github-actions bot added the t-ring-theory Ring theory label Dec 12, 2025
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

PR summary 2dbb742038

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Flat.Equalizer 1126 1130 +4 (+0.36%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Category.Ring.Under.Limits 1
Mathlib.RingTheory.Flat.Equalizer 4

Declarations diff

+ Algebra.kerTensorProductMapIdToAlgHomEquiv
+ Algebra.kerTensorProductMapIdToAlgHomEquiv_symm_apply
+ LinearMap.kerLTensorEquivOfSurjective
+ LinearMap.lTensor_injective_of_exact_of_flat
+ LinearMap.tensorKerEquivOfSurjective_symm_tmul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

Comment on lines 224 to 227
/-- Given surjection `f : M → N` with `N` flat, then `A ⊗ ker f ≃ ker (A ⊗ f)`.
Also see `LinearMap.tensorKerEquiv` for the version with `A` flat instead. -/
def LinearMap.kerLTensorEquivOfSurjective [Module.Flat R P]
(f : N →ₗ[R] P) (hf : Function.Surjective f) (A : Type*) [AddCommGroup A] [Module R A] :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align the variable names in the docstring and the statement.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2026

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jan 6, 2026
Corrected the surjection description in the comment.
@erdOne
Copy link
Member Author

erdOne commented Jan 6, 2026

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): base change of ideal with flat quotients [Merged by Bors] - feat(RingTheory): base change of ideal with flat quotients Jan 6, 2026
@mathlib-bors mathlib-bors bot closed this Jan 6, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants