Skip to content

Conversation

@Jlh18
Copy link
Collaborator

@Jlh18 Jlh18 commented Dec 11, 2025

Step one of several PRs, stemming from #29283


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

PR summary e640e39324

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Category.Grpd -390
Mathlib.CategoryTheory.Groupoid.Grpd.Basic 390

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/CategoryTheory/Category/Grpd.lean` was renamed to `Mathlib/CategoryTheory/Groupoid/Grpd/Basic.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Dec 11, 2025
@Jlh18
Copy link
Collaborator Author

Jlh18 commented Dec 11, 2025

@dagurtomas Thank you for the suggestions. Here is the first PR just moving the Grpd file to Grpd.Basic

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 17, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 6, 2026
@Jlh18 Jlh18 added easy < 20s of review time. See the lifecycle page for guidelines. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 6, 2026
@Jlh18 Jlh18 requested a review from dagurtomas January 6, 2026 19:25
@RemyDegenne RemyDegenne removed their assignment Jan 10, 2026
@alexjbest alexjbest removed their assignment Jan 11, 2026
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 14, 2026
…poid.Grpd.Basic` (#32735)

Step one of several PRs, stemming from  #29283

Co-authored-by: jlh18 <josephhua73@yahoo.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: move CategoryTheory.Category.Grpd to CategoryTheory.Groupoid.Grpd.Basic [Merged by Bors] - refactor: move CategoryTheory.Category.Grpd to CategoryTheory.Groupoid.Grpd.Basic Jan 14, 2026
@mathlib-bors mathlib-bors bot closed this Jan 14, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
eliasjudin pushed a commit to eliasjudin/mathlib4 that referenced this pull request Jan 18, 2026
…poid.Grpd.Basic` (leanprover-community#32735)

Step one of several PRs, stemming from  leanprover-community#29283

Co-authored-by: jlh18 <josephhua73@yahoo.com>
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…poid.Grpd.Basic` (leanprover-community#32735)

Step one of several PRs, stemming from  leanprover-community#29283

Co-authored-by: jlh18 <josephhua73@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-removed A Lean module was (re)moved without a `deprecated_module` annotation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants