Skip to content

Conversation

@BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Dec 7, 2025

As observed on Zulip NoZeroDivisors is a strictly weaker assumption than IsCancelMulZero.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

PR summary 419be563ec

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@BoltonBailey BoltonBailey changed the title chore(MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors chore(RIngTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors Dec 8, 2025
@BoltonBailey BoltonBailey changed the title chore(RIngTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors chore(RingTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors Dec 8, 2025
@ocfnash ocfnash changed the title chore(RingTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors chore(RingTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors in degree_mul and related lemmas. Dec 10, 2025
@ocfnash
Copy link
Contributor

ocfnash commented Dec 10, 2025

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 10, 2025
…ors in `degree_mul` and related lemmas. (#32558)

As observed [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/IsCancelMulZero.20and.20NoZeroDivisors.20for.20semirings/near/562327698) `NoZeroDivisors` is a strictly weaker assumption than `IsCancelMulZero`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors in degree_mul and related lemmas. [Merged by Bors] - chore(RingTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors in degree_mul and related lemmas. Dec 10, 2025
@mathlib-bors mathlib-bors bot closed this Dec 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 3, 2026
This PR creates a new file for lemmas about `MvPolynomial`s over rings which are `NoZeroDivisors`, to make modified versions of lemmas like `degreeOf_C_mul`.

Original PR: #11106

- [x] depends on: #11095
- [x] depends on: #11094
- [x] depends on: #25926 [We need this lemma to establish fact about degreeOf n (p + q)]
- [x] depends on: #32558
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
…over-community#25925)

This PR creates a new file for lemmas about `MvPolynomial`s over rings which are `NoZeroDivisors`, to make modified versions of lemmas like `degreeOf_C_mul`.

Original PR: leanprover-community#11106

- [x] depends on: leanprover-community#11095
- [x] depends on: leanprover-community#11094
- [x] depends on: leanprover-community#25926 [We need this lemma to establish fact about degreeOf n (p + q)]
- [x] depends on: leanprover-community#32558
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…over-community#25925)

This PR creates a new file for lemmas about `MvPolynomial`s over rings which are `NoZeroDivisors`, to make modified versions of lemmas like `degreeOf_C_mul`.

Original PR: leanprover-community#11106

- [x] depends on: leanprover-community#11095
- [x] depends on: leanprover-community#11094
- [x] depends on: leanprover-community#25926 [We need this lemma to establish fact about degreeOf n (p + q)]
- [x] depends on: leanprover-community#32558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants