-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - chore(RingTheory/MvPolynomial): weaken IsCancelMulZero to NoZeroDivisors in degree_mul and related lemmas.
#32558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BoltonBailey
wants to merge
1
commit into
leanprover-community:master
from
BoltonBailey:generalize-nozerodivisors
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onomialOrder and DegLex
4 tasks
PR summary 419be563ecImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
degree_mul and related lemmas.
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
…ors in `degree_mul` and related lemmas. (#32558) As observed [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/IsCancelMulZero.20and.20NoZeroDivisors.20for.20semirings/near/562327698) `NoZeroDivisors` is a strictly weaker assumption than `IsCancelMulZero`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
degree_mul and related lemmas.degree_mul and related lemmas.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 3, 2026
This PR creates a new file for lemmas about `MvPolynomial`s over rings which are `NoZeroDivisors`, to make modified versions of lemmas like `degreeOf_C_mul`. Original PR: #11106 - [x] depends on: #11095 - [x] depends on: #11094 - [x] depends on: #25926 [We need this lemma to establish fact about degreeOf n (p + q)] - [x] depends on: #32558
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Jan 6, 2026
…over-community#25925) This PR creates a new file for lemmas about `MvPolynomial`s over rings which are `NoZeroDivisors`, to make modified versions of lemmas like `degreeOf_C_mul`. Original PR: leanprover-community#11106 - [x] depends on: leanprover-community#11095 - [x] depends on: leanprover-community#11094 - [x] depends on: leanprover-community#25926 [We need this lemma to establish fact about degreeOf n (p + q)] - [x] depends on: leanprover-community#32558
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…over-community#25925) This PR creates a new file for lemmas about `MvPolynomial`s over rings which are `NoZeroDivisors`, to make modified versions of lemmas like `degreeOf_C_mul`. Original PR: leanprover-community#11106 - [x] depends on: leanprover-community#11095 - [x] depends on: leanprover-community#11094 - [x] depends on: leanprover-community#25926 [We need this lemma to establish fact about degreeOf n (p + q)] - [x] depends on: leanprover-community#32558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed on Zulip
NoZeroDivisorsis a strictly weaker assumption thanIsCancelMulZero.