Conversation
- Add buildSendResult helper that includes recall_available/recall_tip when backend returns recall_status in send response - Update +send, +reply, +reply-all, +forward to use buildSendResult - Add "Recall Email" section to mail skill template with recall and get_recall_detail command examples - Regenerate SKILL.md Change-Id: I44317ead8f8a65db81e874cfc3529ffeb21e1384 Co-Authored-By: AI
📝 WalkthroughWalkthroughA new helper function Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@shortcuts/mail/helpers.go`:
- Around line 1946-1948: The recall_tip construction injects mailboxID and
messageID directly into a single-quoted JSON snippet, which breaks the
ready-to-run command if those IDs contain quotes; update the code that builds
result["recall_tip"] to safely escape or serialize the params (e.g., build a Go
map with "user_mailbox_id" and "message_id" and json.Marshal it, or explicitly
escape single quotes/backslashes in mailboxID and messageID) before embedding
into fmt.Sprintf so the resulting lark-cli command is always valid; change the
usage around fmt.Sprintf(...) that sets result["recall_tip"] to use the
serialized/escaped params variable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 883d0245-6b2e-403f-9d38-3d5d124cb1ae
📒 Files selected for processing (7)
shortcuts/mail/helpers.goshortcuts/mail/mail_forward.goshortcuts/mail/mail_reply.goshortcuts/mail/mail_reply_all.goshortcuts/mail/mail_send.goskill-template/domains/mail.mdskills/lark-mail/SKILL.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@0a2e1830edbbf3af7c36d37427bcaa1705e0db07🧩 Skill updatenpx skills add larksuite/cli#feat/mail-recall -y -g |
Summary
recall_availableflag and a ready-to-use recall commandrecallandget_recall_detailcommands undermail user_mailbox.sent_messagesfor recalling sent emails and querying recall progressUsage
Recall a sent email (within 24 hours):
lark-cli mail user_mailbox.sent_messages recall --as user \ --params '{"user_mailbox_id":"me","message_id":"<message_id>"}'Query recall progress:
lark-cli mail user_mailbox.sent_messages get_recall_detail --as user \ --params '{"user_mailbox_id":"me","message_id":"<message_id>"}'Test plan
recall_availableandrecall_tipappear in responserecall_status: availablerecall_status: unavailableSummary by CodeRabbit
Release Notes
New Features
Documentation