Merged
Conversation
Member
|
Issue #43 |
xuelink
approved these changes
Apr 15, 2024
Member
xuelink
left a comment
xuelink
left a comment
There was a problem hiding this comment.
Awesome, gonna attach some commits then uncomment this component and merge this PR, thank you very much for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xuelink I split the sponsors into two components. Not sure what to name them, you can rename the files later down the road if you want. However, the components have a lot of SVG's, I would normally just place the SVG's inside a image directory and reference them using an image tag or object tag, and use an array of objects with all the URL and data and just loop through my lists. But I can't do that cause the SVG's need to access the CSS variables such as var(--color--text) and so on to change with the dark and light theme. But other than that it looks decent. You can change anything you need to for the sponsors. They are all responsive and work well with the light and dark theme.