Skip to content

adds dark and light svg logo to header#47

Merged
xuelink merged 4 commits intolangx:mainfrom
jakebogan01:add-logo-to-header
Apr 12, 2024
Merged

adds dark and light svg logo to header#47
xuelink merged 4 commits intolangx:mainfrom
jakebogan01:add-logo-to-header

Conversation

@jakebogan01
Copy link
Contributor

I went ahead and added a light and dark logo to the header. I commented out the old SVG logo as well as the light SVG logo, leaving the dark logo up to view. I also switched where the link tag is, so it only wraps around the logo and doesn't span across the header.

@xuelink
Copy link
Member

xuelink commented Apr 10, 2024

Screenshot 2024-04-11 at 1 20 36 AM Screenshot 2024-04-11 at 1 20 47 AM @jakebogan01 dark and light mode looks like that

@jakebogan01
Copy link
Contributor Author

jakebogan01 commented Apr 10, 2024

@xuelink The dark mode logo looks great, the light logo looks to be bugging out.
It's suppose to look like this, ignore the white background I just quickly opened up the SVG and took a screenshot of it:

Screenshot 2024-04-10 at 6 26 51 PM

I also just checked the SVG again and it looks fine on my end, not sure why its looking like that for you

@xuelink
Copy link
Member

xuelink commented Apr 10, 2024

@jakebogan01 for both of them, it can stay the same because we are not changing the color of headers for both themes, i think it is also better to use it without background something like https://github.com/langxapp/branding/blob/main/app-resources/icon-foreground.png

@xuelink xuelink self-requested a review April 10, 2024 22:31
@xuelink
Copy link
Member

xuelink commented Apr 10, 2024

@jakebogan01 for example in our social media posts, its used like that for the yellow background and header of the website also doesnt change for the dark/light theme. We can use it the same here as well ;)
Screenshot 2024-04-11 at 1 34 30 AM

@jakebogan01
Copy link
Contributor Author

@xuelink I understand, I will remove the dark logo and keep the other one. I'll have the logo look just like that 👍

@jakebogan01
Copy link
Contributor Author

@xuelink I removed the dark and old SVG logo and replaced it with a normal logo as referenced in your image above. Ready for your review

Copy link
Member

@xuelink xuelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! But still it changes by theme

Kapture.2024-04-12.at.11.40.39.mp4

@xuelink
Copy link
Member

xuelink commented Apr 12, 2024

@jakebogan01 If you are agree with that, i can attach new commit here to fix it and merge it ;) Best

@xuelink xuelink merged commit 3e0fb2f into langx:main Apr 12, 2024
@xuelink xuelink linked an issue Apr 12, 2024 that may be closed by this pull request
@jakebogan01
Copy link
Contributor Author

jakebogan01 commented Apr 12, 2024

@xuelink I tried to replicate that issue, the logo doesn't change based on the theme for me. What browser are you using?

langx-logo-theme-change.mp4

@jakebogan01 jakebogan01 deleted the add-logo-to-header branch April 12, 2024 14:06
@xuelink
Copy link
Member

xuelink commented Apr 12, 2024

@jakebogan01 adding fill="#000" related parts of svg fixed. c1b0866

My Browser:
Screenshot 2024-04-12 at 5 54 14 PM

@xuelink
Copy link
Member

xuelink commented Apr 12, 2024

@jakebogan01 We are also talking about this repo on DG, #codebase channel, Feel free to join: invitation

@jakebogan01
Copy link
Contributor Author

@xuelink thanks for fixing that. Should have thought about that myself. Thanks again, I'll take a look at that today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 : Add a logo in header

2 participants