feat: Add Bulk actions bar on knowledge base table for delete actions#1371
Open
mfortman11 wants to merge 2 commits intorelease-saas-0.1from
Open
feat: Add Bulk actions bar on knowledge base table for delete actions#1371mfortman11 wants to merge 2 commits intorelease-saas-0.1from
mfortman11 wants to merge 2 commits intorelease-saas-0.1from
Conversation
* sdk saas updates * update versions * chore: update uv.lock files after version bump * Require API key or headers; add auth tests Enforce authentication at OpenRAGClient construction by raising AuthenticationError when neither api_key nor extra_headers (nor OPENRAG_API_KEY env var) are provided. Also lightweight formatting cleanups in client request/header construction. Expanded tests: updated the missing-key test and added coverage for extra_headers-only auth, env-var-only auth, and explicit api_key precedence to ensure various auth modes (e.g. IBM headers) are supported and prioritized correctly. * tag as rc1 for testing purposes * chore: update uv.lock files after version bump --------- Co-authored-by: Edwin Jose <edwinjose900@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a Carbon-like bulk actions bar for the knowledge base table selection flow, and also updates both the Python and TypeScript SDKs to support an IBM authentication mode via per-request extra headers (with accompanying version bumps).
Changes:
- Add a
KnowledgeBatchActionsBarUI and swap it in when rows are selected on the knowledge page. - Add SDK support for “IBM auth” by allowing authentication via
extra_headers/extraHeaders(instead of only API key/env var). - Bump SDK versions to a
0.3.0release candidate.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/sdk/test_auth.py | Expands auth construction tests (missing creds, env var, extra headers, precedence). |
| sdks/typescript/src/types.ts | Documents new extraHeaders option on the TS client. |
| sdks/typescript/src/client.ts | Adds extraHeaders support when building request headers. |
| sdks/typescript/package.json | Bumps TS SDK version. |
| sdks/python/uv.lock | Bumps Python SDK version in lockfile. |
| sdks/python/pyproject.toml | Bumps Python SDK version. |
| sdks/python/openrag_sdk/client.py | Adds extra_headers support and adjusts auth validation/headers. |
| frontend/components/knowledge-batch-actions-bar.tsx | New bulk actions bar component (cancel + delete). |
| frontend/app/knowledge/page.tsx | Animates between search bar and bulk actions bar based on selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.ibm.com/lakehouse/tracker/issues/69215
Mirrors the
Batch Actionsbehavior of a table in Carbon https://carbondesignsystem.com/components/data-table/usage/Screen.Recording.2026-04-09.at.4.11.41.PM.mov