Skip to content

fix: change factory-reset functions to delete named volume for opensearch-data#1363

Open
lucaseduoli wants to merge 3 commits intomainfrom
fix/opensearch_volume_factory_reset
Open

fix: change factory-reset functions to delete named volume for opensearch-data#1363
lucaseduoli wants to merge 3 commits intomainfrom
fix/opensearch_volume_factory_reset

Conversation

@lucaseduoli
Copy link
Copy Markdown
Collaborator

This pull request removes support for configuring the OpenSearch data path via environment variables and local directories, fully transitioning OpenSearch data persistence to Docker-managed named volumes. This simplifies configuration and data management, making the system more robust and less error-prone. All related documentation, configuration fields, and code paths for the old directory-based approach have been removed or updated.

Configuration and Environment Variable Cleanup:

  • Removed OPENSEARCH_DATA_PATH from .env.example, the EnvManager, and all related config fields, so OpenSearch data is no longer configurable via environment variables or local paths. [1] [2] [3] [4] [5]

Makefile and Data Reset Updates:

  • Updated the factory-reset and clear-os-data Makefile targets to remove references to the opensearch-data directory and clarify that OpenSearch data is now managed as a Docker volume. [1] [2] [3]

Script and Container Manager Refactor:

  • Refactored scripts/clear_opensearch_data.py and ContainerManager.clear_opensearch_data_volume() to operate on Docker volumes instead of directories, including logic to handle different possible volume names. [1] [2]

Miscellaneous:

  • Adjusted logic for inserting the OPENRAG_VERSION line in .env files to account for the removal of OPENSEARCH_DATA_PATH.

@lucaseduoli lucaseduoli requested a review from mpawlow April 9, 2026 16:38
@lucaseduoli lucaseduoli self-assigned this Apr 9, 2026
@github-actions github-actions bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. labels Apr 9, 2026
@github-actions github-actions bot added documentation 📘 Improvements or additions to documentation frontend 🟨 Issues related to the UI/UX tests bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. documentation 📘 Improvements or additions to documentation labels Apr 9, 2026
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

@zzzming zzzming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove existing env variable. We have other provisioning components depending on it.

@lucaseduoli
Copy link
Copy Markdown
Collaborator Author

@zzzming that env variable was not used, because it does not alter the behavior of the opensearch image. It was an env variable that was exclusive to docker-compose.yml

{{- if .Values.global.opensearch.password }}
OPENSEARCH_PASSWORD={{ .Values.global.opensearch.password | quote }}
{{- end }}
OPENSEARCH_DATA_PATH=./opensearch-data

This comment was marked as outdated.

@github-actions github-actions bot added the lgtm label Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@mpawlow mpawlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaseduoli

Code Review 1

  • See PR comments: (a) to (f)

@github-actions github-actions bot removed the lgtm label Apr 9, 2026
@github-actions github-actions bot added documentation 📘 Improvements or additions to documentation bug 🔴 Something isn't working. and removed bug 🔴 Something isn't working. documentation 📘 Improvements or additions to documentation labels Apr 9, 2026
@lucaseduoli lucaseduoli requested a review from mpawlow April 9, 2026 21:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants