fix: change factory-reset functions to delete named volume for opensearch-data#1363
Open
lucaseduoli wants to merge 3 commits intomainfrom
Open
fix: change factory-reset functions to delete named volume for opensearch-data#1363lucaseduoli wants to merge 3 commits intomainfrom
lucaseduoli wants to merge 3 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
zzzming
requested changes
Apr 9, 2026
Collaborator
zzzming
left a comment
There was a problem hiding this comment.
Please do not remove existing env variable. We have other provisioning components depending on it.
Collaborator
Author
|
@zzzming that env variable was not used, because it does not alter the behavior of the opensearch image. It was an env variable that was exclusive to docker-compose.yml |
rodageve
approved these changes
Apr 9, 2026
| {{- if .Values.global.opensearch.password }} | ||
| OPENSEARCH_PASSWORD={{ .Values.global.opensearch.password | quote }} | ||
| {{- end }} | ||
| OPENSEARCH_DATA_PATH=./opensearch-data |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zzzming
approved these changes
Apr 9, 2026
mpawlow
requested changes
Apr 9, 2026
Contributor
|
Build successful! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes support for configuring the OpenSearch data path via environment variables and local directories, fully transitioning OpenSearch data persistence to Docker-managed named volumes. This simplifies configuration and data management, making the system more robust and less error-prone. All related documentation, configuration fields, and code paths for the old directory-based approach have been removed or updated.
Configuration and Environment Variable Cleanup:
OPENSEARCH_DATA_PATHfrom.env.example, theEnvManager, and all related config fields, so OpenSearch data is no longer configurable via environment variables or local paths. [1] [2] [3] [4] [5]Makefile and Data Reset Updates:
factory-resetandclear-os-dataMakefile targets to remove references to theopensearch-datadirectory and clarify that OpenSearch data is now managed as a Docker volume. [1] [2] [3]Script and Container Manager Refactor:
scripts/clear_opensearch_data.pyandContainerManager.clear_opensearch_data_volume()to operate on Docker volumes instead of directories, including logic to handle different possible volume names. [1] [2]Miscellaneous:
OPENRAG_VERSIONline in.envfiles to account for the removal ofOPENSEARCH_DATA_PATH.