Merged
Conversation
|
✅ Build Successful - Preview Images for this PR: Changed packages: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors authentication middleware and clarifies logging configuration. It extracts bearer token authentication into a custom middleware implementation and renames the environment variable LOG_LEVEL to LOG_CONSOLE_LEVEL to better distinguish console logging configuration from OpenTelemetry logging configuration.
Changes:
- Replaced
hono/bearer-authwith a custombearerAuthmiddleware inlib/middlewares/auth.ts - Renamed
LOG_LEVELenvironment variable toLOG_CONSOLE_LEVELacross all files for clarity - Reordered middleware execution so authentication happens after request logging
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/app.ts | Updated to import custom bearerAuth middleware and moved auth middleware after logger |
| lib/middlewares/auth.ts | New custom bearer auth middleware implementation using HTTPException |
| runtime/.env.template | Renamed LOG_LEVEL to LOG_CONSOLE_LEVEL with updated comments |
| lib/env.ts | Updated environment variable schema from LOG_LEVEL to LOG_CONSOLE_LEVEL |
| lib/logger/index.ts | Updated to use env.LOG_CONSOLE_LEVEL instead of env.LOG_LEVEL |
| lib/worker/index.ts | Updated worker environment to pass LOG_CONSOLE_LEVEL |
| lib/type/env.d.ts | Updated TypeScript type definition for ProcessEnv |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.