Explicitly depend on aws-sdk-v1 #20
Open
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects that use aws-sdk v2
|
@kunday any idea if this is ever going to be merged? If you need help, I would be more than happy to help out with taking over some tasks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloudformer is pulled into a project that uses aws-sdk version 2, bundler reports a version conflict because cloudformer requires version 1.x. To get around this problem and allow both versions to co-exist, AWS have published v1 under a different gem name: aws-sdk-v1.
This PR updates the cloudformer gem dependencies to explicitly depend on the "aws-sdk-v1" gem, which allows it to be used in projects that use v2.
Related to #16.