Skip to content

Conversation

@google-labs-jules
Copy link

@google-labs-jules google-labs-jules bot commented Jan 20, 2026

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix command injection vulnerability in git utils

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command Injection in src/utils/git.ts. The functions searchCommits and getCommitInfo were using child_process.exec with interpolated strings containing user input (query, hash). This allowed arbitrary command execution if a malicious string was provided (e.g. via a manipulated search query).
🎯 Impact: An attacker could execute arbitrary commands on the victim's machine by tricking them into searching for a malicious string or viewing a crafted commit hash.
πŸ”§ Fix: Replaced exec (which spawns a shell) with execFile (which executes the binary directly). Arguments are now passed as an array, preventing shell interpretation of special characters.
βœ… Verification: Created a reproduction script that confirmed the injection was possible with the old code. Updated unit tests (src/utils/__tests__/git.spec.ts) to verify that execFile is called with the correct array arguments and ran them successfully.


PR created automatically by Jules for task 14733649975977161046 started by @kratos06


Summary by cubic

Fixes a critical command injection in git utils by switching from exec to execFile and passing safe argument arrays. Prevents shell interpretation of user input in commit search and info commands.

  • Bug Fixes
    • Replaced child_process.exec with execFile in checkGitInstalled, checkGitRepo, searchCommits, getCommitInfo, and getWorkingState.
    • Passed all git args as arrays (e.g., --format=…, --grep=…), removing string interpolation.
    • Updated tests to mock execFile and verify correct arguments, including cases for missing git and non-repo paths.

Written for commit 85c51dd. Summary will update on new commits.

Refactored git utility functions to use `execFile` instead of `exec`.
This prevents command injection by passing arguments as an array directly to the process, avoiding shell execution.
Updated tests to mock `execFile` and verify correct argument passing.
@google-labs-jules
Copy link
Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants