Skip to content

Conversation

@google-labs-jules
Copy link

@google-labs-jules google-labs-jules bot commented Jan 12, 2026

This PR fixes a critical command injection vulnerability in src/utils/git.ts where user inputs (such as search queries) were being concatenated directly into shell command strings. By switching to execFile and passing arguments as an array, we prevent the shell from interpreting metacharacters in the input.

Vulnerability:
exec(\git log --grep="${query}"`)allows executing arbitrary commands ifquerycontains shell separators like;`.

Fix:
Changed to execFile('git', ['log', '--grep=' + query]).

Verification:
Updated unit tests in src/utils/__tests__/git.spec.ts to verify that execFile is called with the correct array of arguments.


PR created automatically by Jules for task 17536709473318556814 started by @kratos06


Summary by cubic

Fixes a critical command injection in git utilities by switching from child_process.exec to execFile with safe argument arrays. This blocks shell metacharacters from being executed and hardens all git-related commands.

  • Bug Fixes
    • Replaced exec with execFile in src/utils/git.ts for log, show, status, diff, rev-parse, and version checks.
    • Updated unit tests to mock execFile and assert correct argument arrays.
    • Added a security note in .jules/sentinel.md.

Written for commit 8f87b22. Summary will update on new commits.

- Replaced child_process.exec with execFile in src/utils/git.ts to prevent command injection
- Updated all git command invocations to pass arguments as arrays
- Updated tests to mock execFile and verify correct argument passing
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants