Skip to content

rm cmd/ko/main.go#628

Merged
imjasonh merged 1 commit intoko-build:mainfrom
imjasonh:remove-cmd-ko
Mar 2, 2022
Merged

rm cmd/ko/main.go#628
imjasonh merged 1 commit intoko-build:mainfrom
imjasonh:remove-cmd-ko

Conversation

@imjasonh
Copy link
Member

@imjasonh imjasonh commented Mar 1, 2022

We moved cmd/ko/main.go up to ./main.go ~15 months ago in #257. Since then we've warned anyone installing cmd/ko that it's going away.

Let's rip the Band-Aid.

cc @n3wscott

@imjasonh imjasonh requested a review from jonjohnsonjr March 1, 2022 18:53
@imjasonh imjasonh merged commit 967e3eb into ko-build:main Mar 2, 2022
pradeepitm12 added a commit to pradeepitm12/operator that referenced this pull request Mar 3, 2022
With this pr ko-build/ko#628 getting merged
operator Make apply is gives below error

```:cat: building github.com/google/ko/cmd/ko…
cannot find package "github.com/google/ko/cmd/ko" in any of:
	/usr/local/go/src/github.com/google/ko/cmd/ko (from $GOROOT)
	/tmp/tmp.rXMejzqfMj/src/github.com/google/ko/cmd/ko (from $GOPATH)
make: *** [Makefile:26: /home/pradeepkumar/go/src/github.com/tektoncd/operator/.bin/ko] Error 1
```

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
tekton-robot pushed a commit to tektoncd/operator that referenced this pull request Mar 3, 2022
With this pr ko-build/ko#628 getting merged
operator Make apply is gives below error

```:cat: building github.com/google/ko/cmd/ko…
cannot find package "github.com/google/ko/cmd/ko" in any of:
	/usr/local/go/src/github.com/google/ko/cmd/ko (from $GOROOT)
	/tmp/tmp.rXMejzqfMj/src/github.com/google/ko/cmd/ko (from $GOPATH)
make: *** [Makefile:26: /home/pradeepkumar/go/src/github.com/tektoncd/operator/.bin/ko] Error 1
```

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
sm43 pushed a commit to sm43/tektoncd-operator that referenced this pull request May 10, 2022
With this pr ko-build/ko#628 getting merged
operator Make apply is gives below error

```cat building github.com/google/ko/cmd/ko…
cannot find package "github.com/google/ko/cmd/ko" in any of:
	/usr/local/go/src/github.com/google/ko/cmd/ko (from $GOROOT)
	/tmp/tmp.rXMejzqfMj/src/github.com/google/ko/cmd/ko (from $GOPATH)
make: *** [Makefile:26: /home/pradeepkumar/go/src/github.com/tektoncd/operator/.bin/ko] Error 1
```

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
tekton-robot pushed a commit to tektoncd/operator that referenced this pull request May 10, 2022
With this pr ko-build/ko#628 getting merged
operator Make apply is gives below error

```cat building github.com/google/ko/cmd/ko…
cannot find package "github.com/google/ko/cmd/ko" in any of:
	/usr/local/go/src/github.com/google/ko/cmd/ko (from $GOROOT)
	/tmp/tmp.rXMejzqfMj/src/github.com/google/ko/cmd/ko (from $GOPATH)
make: *** [Makefile:26: /home/pradeepkumar/go/src/github.com/tektoncd/operator/.bin/ko] Error 1
```

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants