This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Update the manifest of knative serving and the dependencies for 0.12.0 release#264
Merged
knative-prow-robot merged 2 commits intoknative:masterfrom Jan 23, 2020
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
houshengbo
changed the title
houshengbo
force-pushed
the
update-deps
branch
from
44819bc to
2950093
Compare
jcrossley3
reviewed
Jan 23, 2020
Contributor
jcrossley3
left a comment
jcrossley3
left a comment
There was a problem hiding this comment.
I assume you've checked for any obsolete resources in the new manifest? It's kinda hard to tell due to their re-ordering, but nothing jumped out at me.
Author
|
@jcrossley3 I did it. Manually compared one-by-one. No obsolete resource was found. |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note