This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Add a "DependenciesInstalled" condition that defaults to true#236
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Dec 3, 2019
Merged
Add a "DependenciesInstalled" condition that defaults to true#236knative-prow-robot merged 1 commit intoknative:masterfrom
knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
This allows any other controllers, e.g. platform-specific ones, watching the KnativeServing resource to defer its "Ready" until any deps on that platform, e.g. a service mesh, are successfully installed.
|
The following is the coverage report on the affected files.
|
jcrossley3
added a commit
to openshift-knative/knative-serving-openshift
that referenced
this pull request
Nov 27, 2019
This pulls in changes from this PR: knative/serving-operator#236
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcrossley3, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows any other controllers, e.g. platform-specific ones, watching the KnativeServing resource to defer its "Ready" condition until any deps on that platform, e.g. a service mesh, are successfully installed.
This is effectively a no-op unless some other controller marks the condition as "missing" or "installing".